Skip to content

Revert "Disable url tooltips whilst they are very broken"#23030

Merged
t3chguy merged 1 commit intodevelopfrom
revert-22976-t3chguy-patch-1
Aug 9, 2022
Merged

Revert "Disable url tooltips whilst they are very broken"#23030
t3chguy merged 1 commit intodevelopfrom
revert-22976-t3chguy-patch-1

Conversation

@t3chguy
Copy link
Copy Markdown
Member

@t3chguy t3chguy commented Aug 8, 2022

Reverts #22976

Requires matrix-org/matrix-react-sdk#9139


This change is marked as an internal change (Task), so will not be included in the changelog.

@t3chguy t3chguy added the T-Task Tasks for the team like planning label Aug 8, 2022
@t3chguy t3chguy requested a review from a team as a code owner August 8, 2022 14:53
Copy link
Copy Markdown
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to consider #22953 still?

@t3chguy
Copy link
Copy Markdown
Member Author

t3chguy commented Aug 8, 2022

Don't we need to consider #22953 still?

That's fixed by the required react SDK pr, including tests

Copy link
Copy Markdown
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this side lgtm

@t3chguy t3chguy merged commit 822e262 into develop Aug 9, 2022
@t3chguy t3chguy deleted the revert-22976-t3chguy-patch-1 branch August 9, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-Task Tasks for the team like planning

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants