This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Conversation
t3chguy
force-pushed
the
t3chguy/socials
branch
from
fe32001 to
1b1c482
Compare
jryans
suggested changes
Nov 26, 2020
Collaborator
jryans
left a comment
jryans
left a comment
There was a problem hiding this comment.
Overall, it's looking great, and definitely improves lots of cruft in the auth flows at the same time. 😄 I've added a few small questions on some parts.
nadonomy
approved these changes
Nov 26, 2020
Contributor
nadonomy
left a comment
nadonomy
left a comment
There was a problem hiding this comment.
Have some small iteration tweaks, but happy to iterate on those over time. LGTM!
jryans
approved these changes
Dec 1, 2020
Collaborator
jryans
left a comment
jryans
left a comment
There was a problem hiding this comment.
Thanks, looks great to me! 😄
… t3chguy/socials � Conflicts: � src/i18n/strings/en_EN.json
…cials # Conflicts: # src/i18n/strings/en_EN.json
Member
Author
|
At this point, blocking this until post-RC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements matrix-org/matrix-spec-proposals#2858
Requires matrix-org/matrix-js-sdk#1541
Requires element-hq/element-web#15771
Fixes element-hq/element-web#13024