This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Closed
Conversation
Signed-off-by: Michael Telatynski <[email protected]>
turt2live
suggested changes
Oct 14, 2020
Signed-off-by: Michael Telatynski <[email protected]>
turt2live
approved these changes
Oct 15, 2020
Member
turt2live
left a comment
turt2live
left a comment
There was a problem hiding this comment.
lgtm code-wise - the copy iteration is probably best done by people who know words and not me
| description: _t( | ||
| "The optional identity server is responsible for allowing you " + | ||
| "to find people by their e-mail address.", | ||
| "to find people by their e-mail address and phone number.", |
Member
There was a problem hiding this comment.
still no mention of pending 3pid invites for your own account :(
nadonomy
suggested changes
Nov 18, 2020
Contributor
nadonomy
left a comment
nadonomy
left a comment
There was a problem hiding this comment.
Blocking this on design— adding to the list to figure out how to expose this in a manner which doesn't add more cognitive load (e.g. using a (?) icon).
Member
Author
|
Superseded by #5426 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#15399
Also fixes awkward sizing of the modal.
Before (same dialog for both help buttons):
After:
Copy on both could do with improvements.