This repository was archived by the owner on Sep 11, 2024. It is now read-only.
Replace uses of checkDeviceTrust with getDeviceVerificationStatus#10610
Closed
Replace uses of checkDeviceTrust with getDeviceVerificationStatus#10610
checkDeviceTrust with getDeviceVerificationStatus#10610Conversation
richvdh
added
the
T-Task
richvdh
force-pushed
the
rav/element-r/01_device_verification_status
branch
from
4c0228f to
e0a4392
Compare
richvdh
force-pushed
the
rav/element-r/01_device_verification_status
branch
from
b3b22d0 to
1a36cf2
Compare
richvdh
force-pushed
the
rav/element-r/01_device_verification_status
branch
from
66d666c to
289bbba
Compare
We have a method called `fetchDevicesWithVerification` which is currently used in the new Session manager. Let's use it for the (old) Devices Panel too, because it allows us to check the device verification upfront, rather than on the fly, which is going to be handy when that operation becomes async
these are in an async method, but currently use `some`. We need to invent an `asyncSome` (we already have an `asyncEvery`) and use that
... which means making it async
This is ok except we need an "unmounted" guard because it's an old-style componment
richvdh
force-pushed
the
rav/element-r/01_device_verification_status
branch
from
289bbba to
1e1180b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
matrix-org/matrix-js-sdk#3287 and matrix-org/matrix-js-sdk#3303 added a new API called
getDeviceVerificationStatus. Let's use it.Hopefully this makes sense to review commit-by-commit.
Fixes element-hq/element-web#25092
This change is marked as an internal change (Task), so will not be included in the changelog.