New CryptoApi.getDeviceVerificationStatus api#3287
Merged
Conversation
Define a new base class to replace `DeviceTrustLevel`. The intention is to have a cleaner interface which is easier to expose from the new crypto impl
This is similar to `checkDeviceTrust`, which we're deprecating, but: * is `async`, meaning we can implement it in Rust * Returns a `DeviceVerificationStatus` instead of a `DeviceTrustLevel` * Returns `null` rather than "not verified" if the device is unknown
…evice_verification_status
richvdh
force-pushed
the
rav/element-r/01_device_verification_status
branch
from
52a6b35 to
fc3ed2f
Compare
Member
Author
|
|
... so that we can instantiate it in tests
robintown
approved these changes
Apr 17, 2023
This was referenced Apr 19, 2023
richvdh
added a commit
to matrix-org/matrix-react-sdk
that referenced
this pull request
Apr 24, 2023
…#10663) matrix-org/matrix-js-sdk#3287 and matrix-org/matrix-js-sdk#3303 added a new API called getDeviceVerificationStatus. Let's use it.
This was referenced May 17, 2023
richvdh
added a commit
that referenced
this pull request
May 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define a new endpoint to replace the existing
checkDeviceTrustwhich is awkward to implement in rust.Review commit-by-commit.
Based on #3281.
Part of element-hq/element-web#25092.
This change is marked as an internal change (Task), so will not be included in the changelog.