Fix paginateEventTimeline resolve to boolean#2054
Merged
ajbura merged 3 commits intomatrix-org:developfrom Dec 9, 2021
Merged
Conversation
Earlier paginateEventTimeline used to resolve to chunk instead of returning boolean. Now it return boolean as specified in doc.
Member
|
Can you type L5068-L5070 whilst you're here, these not being implicit any would have caught this bug. |
Member
|
#2055 types L5068-L5069 |
t3chguy
approved these changes
Dec 9, 2021
Member
t3chguy
left a comment
t3chguy
left a comment
There was a problem hiding this comment.
LGTM other than the ask to fix the type to prevent this issue in the future
Contributor
Author
|
Hi, I have tried it but isn't confident that I am doing it correctly. (Complete noob with typescript here :)) |
su-ex
added a commit
to SchildiChat/matrix-js-sdk
that referenced
this pull request
Dec 21, 2021
* Improve fallback key behaviour ([\matrix-org#2037](matrix-org#2037)). * Add new room event filter fields ([\matrix-org#2051](matrix-org#2051)). * Add method to fetch /account/whoami ([\matrix-org#2046](matrix-org#2046)). * Filter out falsey opts in /relations API hits ([\matrix-org#2059](matrix-org#2059)). Fixes element-hq/element-web#20137. * Fix paginateEventTimeline resolve to boolean ([\matrix-org#2054](matrix-org#2054)). * Fix incorrect MSC3089 typings and add null checks ([\matrix-org#2049](matrix-org#2049)).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Earlier paginateEventTimeline used to resolve to chunk instead of resolving to boolean. Now it resolve to boolean as specified in doc.
Signed-off-by: Ajay Bura [email protected]
Here's what your changelog entry will look like:
🐛 Bug Fixes