Improve fallback key behaviour#2037
Merged
uhoreg merged 8 commits intomatrix-org:developfrom Dec 10, 2021
Merged
Conversation
turt2live
approved these changes
Dec 9, 2021
Member
turt2live
left a comment
turt2live
left a comment
There was a problem hiding this comment.
yay, improved fallback keys
Co-authored-by: Travis Ralston <travpc@gmail.com>
Member
Author
|
Apparently, ae68f00 makes jest run for over an hour, which is probably not ideal. Will try to figure out a workaround. |
Member
|
Look into jest.useFakeTimers() |
Member
Author
|
I think my changes exceed the "needs re-review" threshold. (I also added support for unprefixed properties, to match matrix-org/synapse#11541) |
1 task
su-ex
added a commit
to SchildiChat/matrix-js-sdk
that referenced
this pull request
Dec 21, 2021
* Improve fallback key behaviour ([\matrix-org#2037](matrix-org#2037)). * Add new room event filter fields ([\matrix-org#2051](matrix-org#2051)). * Add method to fetch /account/whoami ([\matrix-org#2046](matrix-org#2046)). * Filter out falsey opts in /relations API hits ([\matrix-org#2059](matrix-org#2059)). Fixes element-hq/element-web#20137. * Fix paginateEventTimeline resolve to boolean ([\matrix-org#2054](matrix-org#2054)). * Fix incorrect MSC3089 typings and add null checks ([\matrix-org#2049](matrix-org#2049)).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: do not merge until libolm 3.2.7 is released. (Also, needs a change toDonepackage.jsonto use the newer libolm) (test failures are due to this)Here's what your changelog entry will look like:
✨ Features