Skip to content

return true in grantPermission if app already hasPermission to preven… #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 26, 2023
Merged

return true in grantPermission if app already hasPermission to preven… #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/android/com/gae/scaffolder/plugin/FCMPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,10 @@ public void run() {
try {
if (Build.VERSION.SDK_INT >= 33) { // Android 13+
Copy link

@Belligerator Belligerator Sep 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if SKD is lower than 33? There should be else block with callbackContext.success(1);.

Copy link
Author

@fcristini fcristini Sep 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right it seems ok to me, would you like to apply the fix?

Copy link

@paraschivionut paraschivionut Sep 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix is applied in this PR

boolean hasRuntimePermission = hasRuntimePermission(POST_NOTIFICATIONS);
if (!hasRuntimePermission) {
if (hasRuntimePermission) {
callbackContext.success(1);
}
else {
String[] permissions = new String[]{qualifyPermission(POST_NOTIFICATIONS)};
postNotificationPermissionRequestCallbackContext = callbackContext;
requestPermissions(plugin, POST_NOTIFICATIONS_PERMISSION_REQUEST_ID, permissions);
Expand Down