return true in grantPermission if app already hasPermission to preven… #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t caller to get stuck
| cordova.getThreadPool().execute(new Runnable() { | ||
| public void run() { | ||
| try { | ||
| if (Build.VERSION.SDK_INT >= 33) { // Android 13+ |
There was a problem hiding this comment.
What if SKD is lower than 33? There should be else block with callbackContext.success(1);.
Author
There was a problem hiding this comment.
You are right it seems ok to me, would you like to apply the fix?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
return true in grantPermission if app already hasPermission to prevent caller to get stuck in android 13+ implementation