Roll back the MSRV to Rust 1.48#246
Merged
marshallpierce merged 1 commit intomarshallpierce:masterfrom Aug 26, 2023
Merged
Conversation
Contributor
Author
|
I was going to create an issue but I saw the very amusing "How I, the issue filer, am going to help solve it" :) Awesome library by the way, your code is a pleasure to read. |
tcharding
force-pushed
the
08-09-roll-back-msrv
branch
from
6e0d6f6 to
2a69cc3
Compare
The current MSRV (for non-dev builds) is Rust 1.57 however the codebase does not use any features from edition 2021 (landed Rust 1.56) except the `TryFrom` trait. If we explicitly import `core::convert::tryFrom` we can stay on edition 2018. The `rust-version` manifest option was added in Rust 1.56 but lets leave it there as added documentation of the MSRV and in preparation for bumping the MSRV when needed. Rust 1.48 is a suitably old toolchain version, it is in Debian oldstable. Roll back the crate MSRV to Rust 1.48
tcharding
force-pushed
the
08-09-roll-back-msrv
branch
from
2a69cc3 to
a383018
Compare
Contributor
Author
|
PR currently uses |
Owner
|
If planned obsolescence was taken as a motivating goal, the result would be Debian... I'll take care of the trait tweaking. The _ thing is to avoid being able to accidentally refer to things by their "bare" name, in keeping with the habit I picked up from working on ring of leaving a bit of the module path intact when working directly on types from other crates. |
Contributor
Author
|
Thanks man! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current MSRV (for non-dev builds) is Rust 1.57 however the codebase does not use any features from edition 2021 (landed Rust 1.56) except the
TryFromtrait.If we explicitly import
core::convert::tryFromwe can stay on edition 2018.The
rust-versionmanifest option was added in Rust 1.56 but lets leave it there as added documentation of the MSRV and in preparation for bumping the MSRV when needed.Rust 1.48 is a suitably old toolchain version, it is the toolchain included in Debian Bullseye.