Skip to content

Commit 6e0d6f6

Browse files
committed
Roll back the MSRV
The current MSRV (for non-dev builds) is Rust 1.57 however the codebase does not use any features from edition 2021 (landed Rust 1.56) except the `TryFrom` trait. If we explicitly import `core::convert::tryFrom` we can stay on edition 2018. The `rust-version` manifest option was added in Rust 1.56 but lets leave it there as added documentation of the MSRV and in preparation for bumping the MSRV when needed. Rust 1.48 is a suitably old toolchain version, it is in Debian oldstable. Roll back the crate MSRV to Rust 1.48
1 parent 1e8246a commit 6e0d6f6

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

Cargo.toml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,10 @@ readme = "README.md"
99
keywords = ["base64", "utf8", "encode", "decode", "no_std"]
1010
categories = ["encoding"]
1111
license = "MIT OR Apache-2.0"
12-
edition = "2021"
12+
edition = "2018"
1313
# dev-dependencies require 1.60, but the main code doesn't
14-
rust-version = "1.57.0"
14+
# This option was added in 1.56, keep it for when we bump MSRV.
15+
rust-version = "1.48.0"
1516

1617
[[bench]]
1718
name = "benchmarks"

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ optionally may allow other behaviors.
6363

6464
## Rust version compatibility
6565

66-
The minimum supported Rust version is 1.57.0.
66+
The minimum supported Rust version is 1.48.0.
6767

6868
# Contributing
6969

src/alphabet.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
//! Provides [Alphabet] and constants for alphabets commonly used in the wild.
22
33
use crate::PAD_BYTE;
4+
use core::convert::TryFrom;
45
use core::fmt;
56
#[cfg(any(feature = "std", test))]
67
use std::error;

0 commit comments

Comments
 (0)