Skip to content

fix: attribute tags pre analyze transforms #2886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2025
Merged

fix: attribute tags pre analyze transforms #2886

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/lemon-coats-grow.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@marko/runtime-tags": patch
---

Fix attribute tags not being included in pre analyze transforms.
19 changes: 13 additions & 6 deletions packages/runtime-tags/src/translator/visitors/program/pre-analyze.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,19 @@ export function preAnalyze(program: t.NodePath<t.Program>) {

function normalizeBody(
state: State,
body: t.NodePath<
t.Program["body"][number] | t.MarkoTagBody["body"][number]
>[],
body:
| undefined
| t.NodePath<
| t.Program["body"][number]
| t.MarkoTagBody["body"][number]
| t.MarkoTag["attributeTags"]
>[],
) {
for (const child of body) {
if (child.isMarkoTag()) {
normalizeTag(state, child);
if (body?.length) {
for (const child of body) {
if (child.isMarkoTag()) {
normalizeTag(state, child);
}
}
}
}
Expand All @@ -40,6 +46,7 @@ function normalizeTag(state: State, tag: t.NodePath<t.MarkoTag>) {
const { node } = tag;
const { name, attributes } = node;
normalizeBody(state, tag.get("body").get("body"));
normalizeBody(state, tag.get("attributeTags"));

if (node.var) {
const insertions = getAssignmentInsertions(node.var);
Expand Down