fix: attribute tags pre analyze transforms

[DylanPiercey]

No description provided.

[changeset-bot]

🦋 Changeset detected

Latest commit: 266881c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@marko/runtime-tags	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[coderabbitai]

Walkthrough

• Added a changeset (.changeset/lemon-coats-grow.md) specifying a patch bump for "@marko/runtime-tags" with commit message: "Fix attribute tags not being included in pre analyze transforms."
• Updated packages/runtime-tags/src/translator/visitors/program/pre-analyze.ts:
  • normalizeBody now accepts undefined and t.MarkoTag["attributeTags"].
  • Added null/length guards before processing bodies.
  • normalizeTag now calls normalizeBody for tag.get("attributeTags") in addition to the main body.
• No public API changes; updates are internal to pre-analyze normalization.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.
Description Check	❓ Inconclusive	The pull request description is empty and provides no context or details about the changes, making it too generic to assess its relevance to the code modifications.	Please add a brief description summarizing the purpose of the changes, such as the new attributeTags normalization in pre-analyze transforms and the related package bump.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title clearly and concisely summarizes the main change by indicating a fix to attribute tags in the pre-analyze transform phase, which directly matches the code updates.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix-attr-tag-pre-analyze

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

.changeset/lemon-coats-grow.md (1)

5-5: Hyphenate “pre-analyze” for consistency.

Consider changing “pre analyze” → “pre-analyze” to match the term used elsewhere and keep the summary polished.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c1d752c and eaed74c.

📒 Files selected for processing (5)

• .changeset/lemon-coats-grow.md (1 hunks)
• packages/runtime-tags/src/__tests__/fixtures/dynamic-tag-input-intersection/__snapshots__/dom.expected/tags/my-tag.js (1 hunks)
• packages/runtime-tags/src/__tests__/fixtures/dynamic-tag-input-intersection/__snapshots__/dom.expected/template.hydrate.js (1 hunks)
• packages/runtime-tags/src/__tests__/fixtures/dynamic-tag-input-intersection/__snapshots__/html.expected/tags/my-tag.js (1 hunks)
• packages/runtime-tags/src/translator/visitors/program/pre-analyze.ts (2 hunks)

🧰 Additional context used

🧬 Code graph analysis (2)

packages/runtime-tags/src/translator/visitors/program/pre-analyze.ts (1)

packages/runtime-tags/src/translator/index.ts (2)

• Program (68-70)
• MarkoTagBody (88-90)

packages/runtime-tags/src/__tests__/fixtures/dynamic-tag-input-intersection/__snapshots__/html.expected/tags/my-tag.js (1)

packages/runtime-tags/src/__tests__/fixtures/dynamic-tag-input-intersection/__snapshots__/html.expected/template.js (1)

• $scope0_id (4-4)

🪛 LanguageTool

.changeset/lemon-coats-grow.md

[grammar] ~5-~5: Use a hyphen to join words.
Context: ...attribute tags not being included in pre analyze transforms.

(QB_NEW_EN_HYPHEN)

---

[grammar] ~5-~5: There might be a mistake here.
Context: ...eing included in pre analyze transforms.

(QB_NEW_EN)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: test: node@22
• GitHub Check: test: node@18
• GitHub Check: test: node@20

🔇 Additional comments (3)

packages/runtime-tags/src/__tests__/fixtures/dynamic-tag-input-intersection/__snapshots__/dom.expected/template.hydrate.js (1)

1-22: Snapshot update looks correct.

The resumable content call and size annotation match the translator change.

packages/runtime-tags/src/__tests__/fixtures/dynamic-tag-input-intersection/__snapshots__/dom.expected/tags/my-tag.js (1)

4-4: Snapshot refresh looks good.

Switching to _content_resume aligns with the new pre-analyze behavior.

packages/runtime-tags/src/__tests__/fixtures/dynamic-tag-input-intersection/__snapshots__/html.expected/tags/my-tag.js (1)

12-16: HTML snapshot change makes sense.

Passing the scope id into _content_resume matches the regenerated DOM fixtures.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

.changeset/lemon-coats-grow.md (1)

5-5: Polish the description: hyphenate and use imperative mood.

Improve clarity and align with common style.

-Fix attribute tags not being included in pre analyze transforms.
+Include attribute tags in pre-analyze transforms.

Based on static analysis hints

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between eaed74c and 266881c.

📒 Files selected for processing (2)

• .changeset/lemon-coats-grow.md (1 hunks)
• packages/runtime-tags/src/translator/visitors/program/pre-analyze.ts (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• packages/runtime-tags/src/translator/visitors/program/pre-analyze.ts

🧰 Additional context used

🪛 LanguageTool

.changeset/lemon-coats-grow.md

[grammar] ~5-~5: Use a hyphen to join words.
Context: ...attribute tags not being included in pre analyze transforms.

(QB_NEW_EN_HYPHEN)

---

[grammar] ~5-~5: There might be a mistake here.
Context: ...eing included in pre analyze transforms.

(QB_NEW_EN)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

• GitHub Check: test: node@20
• GitHub Check: test: node@18
• GitHub Check: test: node@22

🔇 Additional comments (1)

.changeset/lemon-coats-grow.md (1)

1-3: Changeset front matter looks correct.

Package and bump type are valid for a patch release.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.15%. Comparing base (c1d752c) to head (266881c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2886   +/-   ##
=======================================
  Coverage   88.15%   88.15%           
=======================================
  Files         371      371           
  Lines       46128    46135    +7     
  Branches     3688     3689    +1     
=======================================
+ Hits        40662    40669    +7     
  Misses       5431     5431           
  Partials       35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.