Skip to content

remove string charts for column header #7039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 4, 2025
Merged

remove string charts for column header #7039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1b0bfc0
show val counts chart for <= 5 unique values cols
Light2Dark Nov 3, 2025
6c140f6
add constants and logic
Light2Dark Nov 3, 2025
62d3479
remove string charts
Light2Dark Nov 3, 2025
f8d5f03
removal of constant
Light2Dark Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions marimo/_plugins/ui/_impl/table.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -980,14 +980,10 @@ def _get_column_summaries(

# For now, we only compute value counts for categorical columns and small tables
external_type = external_type.lower()
if (
column_type == "string"
and ("cat" in external_type or "enum" in external_type)
or (
column_type == "string"
and total_rows <= CHART_MAX_ROWS_STRING_VALUE_COUNTS
)
):
categorical_type = (
"cat" in external_type or "enum" in external_type
)
if column_type == "string" and categorical_type:
try:
val_counts = self._get_value_counts(
column, DEFAULT_VALUE_COUNTS_SIZE, total_rows
Expand Down
23 changes: 1 addition & 22 deletions tests/_plugins/ui/_impl/test_table.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1055,29 +1055,8 @@ def test_rows_string_value_counts_limit(self) -> None:
)
table = ui.table(data)
summaries = table._get_column_summaries(ColumnSummariesArgs())
assert summaries.value_counts == {
"a": [
ValueCount(
value="unique values",
count=CHART_MAX_ROWS_STRING_VALUE_COUNTS,
)
]
}
assert summaries.data is None

# If >20k rows, we should not get value_counts
data = pd.DataFrame(
{
"a": [
str(i)
for i in range(CHART_MAX_ROWS_STRING_VALUE_COUNTS + 1)
]
}
)
table = ui.table(data)
summaries = table._get_column_summaries(ColumnSummariesArgs())
assert summaries.value_counts == {} # too many unique values
assert summaries.data is None
assert summaries.value_counts == {}

def test_with_smaller_limit(self, table: ui.table) -> None:
value_counts = table._get_value_counts(
Expand Down
Loading