Skip to content

remove string charts for column header #7039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 4, 2025
Merged

remove string charts for column header #7039

merged 4 commits into from
Nov 4, 2025

Conversation

@Light2Dark
Copy link
Contributor

@Light2Dark Light2Dark commented Nov 3, 2025 •
edited
Loading

📝 Summary

Goes back to old behaviour, only display these charts for categorical types.

CleanShot 2025-11-03 at 23 06 58

🔍 Description of Changes

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • I have added tests for the changes made.
  • I have run the code and verified that it works as expected.

@vercel
Copy link

vercel bot commented Nov 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
marimo-docs Ready Ready Preview Comment Nov 3, 2025 6:32am

@Light2Dark Light2Dark changed the title show val counts chart for <= 5 unique values cols show string column charts only for columns with <=5 unique values Nov 3, 2025
@Light2Dark Light2Dark changed the title show string column charts only for columns with <=5 unique values only show string column charts for columns with less than 5 unique values Nov 3, 2025
@Light2Dark Light2Dark changed the title only show string column charts for columns with less than 5 unique values only show string charts for columns with less than 5 unique values Nov 3, 2025
@Light2Dark Light2Dark marked this pull request as draft November 3, 2025 02:12
@Light2Dark Light2Dark changed the title only show string charts for columns with less than 5 unique values remove string charts for column header Nov 3, 2025
@Light2Dark Light2Dark marked this pull request as ready for review November 3, 2025 15:07
@Light2Dark Light2Dark merged commit 77de0bf into main Nov 4, 2025
39 of 41 checks passed
@Light2Dark Light2Dark deleted the sham/remove-charts-string-cols branch November 4, 2025 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mscolnick mscolnick mscolnick approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Light2Dark @mscolnick