Skip to content

fix: manually move copilot file extension from js to cjs #6727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 10, 2025
Merged

fix: manually move copilot file extension from js to cjs #6727

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c529cb
fix: manually move copilot file extension from js to cjs
mscolnick Oct 10, 2025
254ef68
move.js
mscolnick Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion marimo/_server/lsp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ def get_command(self) -> list[str]:
LOGGER.debug("LSP binary not found at %s", lsp_bin)
return []

copilot_bin = self._lsp_dir() / "copilot" / "language-server.js"
copilot_bin = self._lsp_dir() / "copilot" / "language-server.cjs"
log_file = _loggers.get_log_directory() / "github-copilot-lsp.log"

# Use typed format to avoid quoting issues: copilot:<binary_path>
Expand Down
2 changes: 1 addition & 1 deletion packages/lsp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"license": "Apache-2.0",
"scripts": {
"build:ts": "tsup index.ts --format cjs --minify",
"build:deps": "cp -LR node_modules/@github/copilot-language-server/dist/ dist/",
"build:deps": "cp -LR node_modules/@github/copilot-language-server/dist/ dist/ && mv dist/language-server.js dist/language-server.cjs",
"typecheck": "tsgo",
"build": "pnpm run build:ts && pnpm run build:deps",
"test": "vitest"
Expand Down
2 changes: 1 addition & 1 deletion tests/_server/test_lsp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ def test_copilot_server_uses_typed_format(tmp_path: Path) -> None:

copilot_dir = lsp_dir_with_spaces / "copilot"
copilot_dir.mkdir()
copilot_bin = copilot_dir / "language-server.js"
copilot_bin = copilot_dir / "language-server.cjs"
copilot_bin.touch()

# Mock the _lsp_dir method to return our test directory
Expand Down
Loading