Skip to content

Conversation

@mscolnick
Copy link
Contributor

@mscolnick mscolnick commented Oct 10, 2025

Fixes #6718

Newer versions of node support ejs so they now try to parse .js files based on the package.json module type. This comes from a downstream dep but we manually move .js to .cjs

@mscolnick mscolnick requested a review from manzt as a code owner October 10, 2025 01:23
@vercel
Copy link

vercel bot commented Oct 10, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
marimo-docs Ready Ready Preview Comment Oct 10, 2025 5:53am

manzt
manzt previously approved these changes Oct 10, 2025
@@ -0,0 +1,22 @@
#!/usr/bin/env node
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a benefit of this over cp and mv? If so can we add a comment?

@mscolnick mscolnick merged commit 6198c88 into main Oct 10, 2025
39 of 41 checks passed
@mscolnick mscolnick deleted the ms/js-to-cjs branch October 10, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working merge when ready

Projects

None yet

Development

Successfully merging this pull request may close these issues.

copilot lsp process crashes when containing package.json type is module

4 participants