Skip to content

Conversation

@Haleshot
Copy link
Contributor

📝 Summary

Fix make-fe failing in Windows by adding cross-env to remaining npm scripts that use env variables.

Builds on #3242 which initially added cross-env but missed some scripts.

🔍 Description of Changes

The make fe command was failing on Windows because several npm scripts in frontend/package.json were using Unix-style environment variable syntax (e.g., NODE_OPTIONS=--max-old-space-size=4096) which isn't recognized by Windows PowerShell/CMD.

Added cross-env prefix to all remaining scripts that set environment variables:
The cross-env package was already installed as a dev dependency from #3242, so no additional dependencies needed.

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • I have added tests for the changes made.
  • I have run the code and verified that it works as expected.

📜 Reviewers

@akshayka OR @mscolnick

@vercel
Copy link

vercel bot commented May 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 27, 2025 4:30am

@mscolnick mscolnick merged commit cbee510 into marimo-team:main May 27, 2025
20 checks passed
@github-actions
Copy link

🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.13.13-dev11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants