Commit cbee510
authored
## 📝 Summary
Fix `make-fe` failing in Windows by adding `cross-env` to remaining npm
scripts that use env variables.
Builds on #3242 which initially added `cross-env` but missed some
scripts.
## 🔍 Description of Changes
The `make fe` command was failing on Windows because several npm scripts
in `frontend/package.json` were using Unix-style environment variable
syntax (e.g., `NODE_OPTIONS=--max-old-space-size=4096`) which isn't
recognized by Windows PowerShell/CMD.
Added `cross-env` prefix to all remaining scripts that set environment
variables:
The `cross-env` package was already installed as a dev dependency from
#3242, so no additional dependencies needed.
## 📋 Checklist
- [x] I have read the [contributor
guidelines](https://github.com/marimo-team/marimo/blob/main/CONTRIBUTING.md).
- [ ] For large changes, or changes that affect the public API: this
change was discussed or approved through an issue, on
[Discord](https://marimo.io/discord?ref=pr), or the community
[discussions](https://github.com/marimo-team/marimo/discussions) (Please
provide a link if applicable).
- [ ] I have added tests for the changes made.
- [x] I have run the code and verified that it works as expected.
## 📜 Reviewers
@akshayka OR @mscolnick
Signed-off-by: Srihari Thyagarajan <[email protected]>
1 parent cfce4d7 commit cbee510
1 file changed
+5
-5
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
157 | 157 | | |
158 | 158 | | |
159 | 159 | | |
160 | | - | |
| 160 | + | |
161 | 161 | | |
162 | 162 | | |
163 | 163 | | |
164 | | - | |
| 164 | + | |
165 | 165 | | |
166 | 166 | | |
167 | 167 | | |
168 | 168 | | |
169 | | - | |
| 169 | + | |
170 | 170 | | |
171 | 171 | | |
172 | 172 | | |
173 | 173 | | |
174 | | - | |
175 | | - | |
| 174 | + | |
| 175 | + | |
176 | 176 | | |
177 | 177 | | |
178 | 178 | | |
| |||
0 commit comments