Skip to content

Commit cbee510

Browse files
authored
fix: update package.json scripts to use cross-env for env variable mgmt (#5087)
## 📝 Summary Fix `make-fe` failing in Windows by adding `cross-env` to remaining npm scripts that use env variables. Builds on #3242 which initially added `cross-env` but missed some scripts. ## 🔍 Description of Changes The `make fe` command was failing on Windows because several npm scripts in `frontend/package.json` were using Unix-style environment variable syntax (e.g., `NODE_OPTIONS=--max-old-space-size=4096`) which isn't recognized by Windows PowerShell/CMD. Added `cross-env` prefix to all remaining scripts that set environment variables: The `cross-env` package was already installed as a dev dependency from #3242, so no additional dependencies needed. ## 📋 Checklist - [x] I have read the [contributor guidelines](https://github.com/marimo-team/marimo/blob/main/CONTRIBUTING.md). - [ ] For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on [Discord](https://marimo.io/discord?ref=pr), or the community [discussions](https://github.com/marimo-team/marimo/discussions) (Please provide a link if applicable). - [ ] I have added tests for the changes made. - [x] I have run the code and verified that it works as expected. ## 📜 Reviewers @akshayka OR @mscolnick Signed-off-by: Srihari Thyagarajan <[email protected]>
1 parent cfce4d7 commit cbee510

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

frontend/package.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -157,22 +157,22 @@
157157
},
158158
"scripts": {
159159
"preinstall": "npx only-allow pnpm",
160-
"ci": "CI=true run-s lint typecheck test build",
160+
"ci": "cross-env CI=true run-s lint typecheck test build",
161161
"start": "vite",
162162
"dev": "vite",
163163
"build:watch": "vite build --watch --outDir ../marimo/_static",
164-
"build": "NODE_OPTIONS=--max-old-space-size=4096 vite build",
164+
"build": "cross-env NODE_OPTIONS=--max-old-space-size=4096 vite build",
165165
"test": "vitest",
166166
"typecheck": "tsc --noEmit",
167167
"lint": "run-s lint:eslint lint:stylelint lint:biome format",
168168
"lint:biome": "biome lint --diagnostic-level=warn --write .",
169-
"lint:eslint": "TIMING=1 eslint src e2e-tests --fix",
169+
"lint:eslint": "cross-env TIMING=1 eslint src e2e-tests --fix",
170170
"lint:stylelint": "stylelint src/**/*.css --fix",
171171
"format": "biome format --write .",
172172
"preview": "vite preview",
173173
"dev:islands": "cross-env VITE_MARIMO_ISLANDS=true vite --config islands/vite.config.mts",
174-
"build:islands": "VITE_MARIMO_ISLANDS=true vite --config islands/vite.config.mts build",
175-
"preview:islands": "VITE_MARIMO_VERSION='0.4.6' VITE_MARIMO_ISLANDS=true vite --config islands/vite.config.mts build",
174+
"build:islands": "cross-env VITE_MARIMO_ISLANDS=true vite --config islands/vite.config.mts build",
175+
"preview:islands": "cross-env VITE_MARIMO_VERSION='0.4.6' VITE_MARIMO_ISLANDS=true vite --config islands/vite.config.mts build",
176176
"storybook": "storybook dev -p 6006",
177177
"build-storybook": "storybook build"
178178
},

0 commit comments

Comments
 (0)