Skip to content

Add constructor to SimulatorRunner's list of python bindings #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
apojomovsky merged 1 commit into from
Feb 26, 2018
Merged

Add constructor to SimulatorRunner's list of python bindings #268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backend/python_examples/realtime_rate_changer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ def main():

simulator = build_simple_car_simulator()

runner = SimulatorRunner(simulator, 0.001, initial_realtime_rate, False)
runner = SimulatorRunner(simulator, 0.001, initial_realtime_rate)

rate_changer = RealtimeRateChanger(runner, initial_steps)

Expand Down
5 changes: 1 addition & 4 deletions backend/simulation_runner_py.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,8 @@ namespace {
PYBIND11_MODULE(simulation_runner_py, m) {
py::class_<SimulatorRunner>(m, "SimulatorRunner")
.def(py::init<unique_ptr<AutomotiveSimulator<double>>, double>())
// TODO(basicNew): Add the missing
// `unique_ptr<AutomotiveSimulator<double>>, double, double>()`
// constructor. Note that this means overloading by type, which I think
// will need a custom python constructor.
.def(py::init<unique_ptr<AutomotiveSimulator<double>>, double, bool>())
.def(py::init<unique_ptr<AutomotiveSimulator<double>>, double, double>())
.def(py::init<unique_ptr<AutomotiveSimulator<double>>, double, double,
bool>())
.def("SetRealtimeRate", &SimulatorRunner::SetRealtimeRate)
Expand Down