Skip to content

Conversation

@apojomovsky
Copy link

@apojomovsky apojomovsky commented Feb 26, 2018

Fixes #256

  • Adds the missing SimulatorRunner's constructor with arguments of type <AutomotiveSimulator<double>>, double, double> by making use of the fix pushed here.

This PR goes hand-in-hand with ToyotaResearchInstitute/delphyne-gui#60.

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, but I think @basicNew should weigh in before we merge.

Copy link

@basicNew basicNew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @apojomovsky

@apojomovsky
Copy link
Author

Thanks guys, I'm merging both PRs now.

@apojomovsky apojomovsky merged commit 0ef0852 into master Feb 26, 2018
@apojomovsky apojomovsky deleted the fix_pybind11_overloaded_constructors branch February 26, 2018 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add overloaded constructor on python binding

4 participants