feat: ability to upgrade name and symbol#199
Closed
0xIryna wants to merge 2 commits intospoke-upgradeablefrom
Closed
feat: ability to upgrade name and symbol#1990xIryna wants to merge 2 commits intospoke-upgradeablefrom
0xIryna wants to merge 2 commits intospoke-upgradeablefrom
Conversation
PierrickGT
reviewed
May 14, 2025
src/MToken.sol
Outdated
| } | ||
|
|
||
| // keccak256(abi.encode(uint256(keccak256("m0.storage.MToken")) - 1)) & ~bytes32(uint256(0xff)) | ||
| bytes32 private constant _M_TOKEN_STORAGE_SLOT = 0x93466981a55ce4da70da67506024f05bd15faf7fdab908fab669c24c9fb04d00; |
Member
There was a problem hiding this comment.
Has the hash been updated?
I get 0xeb521740570240fc3b71275bd090460409d92adf7cec95ba2df10066ee73c700 when calling the code above.
PierrickGT
approved these changes
May 14, 2025
Author
|
Decided not to upgrade name and symbol |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires m0-foundation/common#43 to be merged first