Skip to content

feat: virtual name and symbol#43

Merged
PierrickGT merged 1 commit intofeat/add-safe32from
feat/erc20-extended-upgradeable
May 14, 2025
Merged

feat: virtual name and symbol#43
PierrickGT merged 1 commit intofeat/add-safe32from
feat/erc20-extended-upgradeable

Conversation

@PierrickGT
Copy link
Copy Markdown
Member

No description provided.

@PierrickGT PierrickGT requested a review from toninorair May 13, 2025 00:01
@github-actions
Copy link
Copy Markdown

Changes to gas cost

Generated at commit: 30a382f674ec9f7681aae677dfc86a43885d520a, compared to commit: 9bc6615b72084bccd715204fd18c04afabba55fc

🧾 Summary (20% most significant diffs)

Contract Method Avg (+/-) %
ERC20ExtendedHandler mint +605 ❌ +0.82%
ERC20ExtendedHarness receiveWithAuthorization(address,address,uint256,uint256,uint256,bytes32,bytes)
receiveWithAuthorization(address,address,uint256,uint256,uint256,bytes32,bytes32,bytes32)
receiveWithAuthorization(address,address,uint256,uint256,uint256,bytes32,uint8,bytes32,bytes32)
transferWithAuthorization(address,address,uint256,uint256,uint256,bytes32,bytes)
transferWithAuthorization(address,address,uint256,uint256,uint256,bytes32,bytes32,bytes32)
transferWithAuthorization(address,address,uint256,uint256,uint256,bytes32,uint8,bytes32,bytes32)
-310 ✅
-310 ✅
-293 ✅
-309 ✅
-309 ✅
-294 ✅
-0.38%
-0.38%
-0.37%
-0.38%
-0.38%
-0.37%

Full diff report 👇
Contract Deployment Cost (+/-) Method Min (+/-) % Avg (+/-) % Median (+/-) % Max (+/-) % # Calls (+/-)
ERC20ExtendedHandler 1,370,312 (0) approve
burn
mint
transfer
transferFrom
32,893 (0)
48,291 (0)
679 (0)
780 (0)
886 (0)
0.00%
0.00%
0.00%
0.00%
0.00%
52,603 (+26)
50,529 (-1)
74,688 (+605)
63,544 (+189)
63,912 (+26)
+0.05%
-0.00%
+0.82%
+0.30%
+0.04%
52,877 (0)
50,619 (0)
69,263 (+24)
63,796 (0)
64,256 (0)
0.00%
0.00%
+0.03%
0.00%
0.00%
53,189 (0)
50,815 (0)
103,691 (0)
63,992 (0)
136,419 (+71,967)
0.00%
0.00%
0.00%
0.00%
+111.66%
1,253 (-27)
1,360 (+46)
1,223 (-58)
1,247 (-26)
1,342 (+65)
ERC20ExtendedHarness 2,825,334 (-12) approve
burn
mint
permit
receiveWithAuthorization(address,address,uint256,uint256,uint256,bytes32,bytes)
receiveWithAuthorization(address,address,uint256,uint256,uint256,bytes32,bytes32,bytes32)
receiveWithAuthorization(address,address,uint256,uint256,uint256,bytes32,uint8,bytes32,bytes32)
transfer
transferFrom
transferWithAuthorization(address,address,uint256,uint256,uint256,bytes32,bytes)
transferWithAuthorization(address,address,uint256,uint256,uint256,bytes32,bytes32,bytes32)
transferWithAuthorization(address,address,uint256,uint256,uint256,bytes32,uint8,bytes32,bytes32)
26,852 (0)
24,510 (-12)
29,072 (+12)
24,983 (-12)
63,860 (-17,884)
62,904 (-17,884)
32,009 (0)
24,511 (-12)
25,373 (-12)
63,694 (-17,876)
62,870 (-17,876)
31,918 (0)
0.00%
-0.05%
+0.04%
-0.05%
-21.88%
-22.14%
0.00%
-0.05%
-0.05%
-21.91%
-22.14%
0.00%
46,672 (+48)
29,369 (-17)
65,105 (+87)
62,587 (-84)
81,824 (-310)
80,868 (-310)
78,622 (-293)
31,463 (+20)
34,047 (-6)
81,670 (-309)
80,846 (-309)
78,664 (-294)
+0.10%
-0.06%
+0.13%
-0.13%
-0.38%
-0.38%
-0.37%
+0.06%
-0.02%
-0.38%
-0.38%
-0.37%
46,848 (0)
29,310 (0)
69,112 (0)
77,557 (-16)
82,104 (-12)
81,148 (-12)
81,418 (-12)
29,589 (0)
32,789 (0)
81,954 (-8)
81,130 (-8)
81,286 (-12)
0.00%
0.00%
0.00%
-0.02%
-0.01%
-0.01%
-0.01%
0.00%
0.00%
-0.01%
-0.01%
-0.01%
47,148 (0)
35,282 (0)
69,472 (0)
78,515 (+12)
82,500 (0)
81,544 (0)
81,814 (0)
47,873 (0)
54,949 (+1,076)
82,346 (+20)
81,522 (+12)
81,682 (+20)
0.00%
0.00%
0.00%
+0.02%
0.00%
0.00%
0.00%
0.00%
+2.00%
+0.02%
+0.01%
+0.02%
2,284 (-25)
1,873 (+46)
4,818 (-57)
1,542 (0)
257 (0)
257 (0)
271 (0)
1,758 (-22)
2,108 (+63)
257 (0)
257 (0)
270 (0)
ContractHelperHarness 430,744 (0) getContractFrom 1,910 (0) 0.00% 2,123 (-6) -0.28% 2,145 (0) 0.00% 2,192 (0) 0.00% 269 (0)
SignatureCheckerHarness 985,562 (0) isValidECDSASignature(address,bytes32,bytes)
isValidECDSASignature(address,bytes32,bytes32,bytes32)
isValidSignature
recoverECDSASigner(bytes32,bytes)
recoverECDSASigner(bytes32,bytes32,bytes32)
recoverECDSASigner(bytes32,uint8,bytes32,bytes32)
validateECDSASignature(address,bytes32,bytes)
validateECDSASignature(address,bytes32,bytes32,bytes32)
2,236 (0)
1,734 (0)
5,743 (0)
1,971 (0)
1,524 (0)
1,542 (0)
2,100 (0)
1,641 (0)
0.00%
0.00%
0.00%
0.00%
0.00%
0.00%
0.00%
0.00%
6,065 (+1)
5,578 (+2)
6,203 (+2)
5,726 (+2)
5,293 (+2)
5,297 (+2)
5,929 (+1)
5,492 (+2)
+0.02%
+0.04%
+0.03%
+0.03%
+0.04%
+0.04%
+0.02%
+0.04%
6,104 (+20)
5,602 (+20)
6,170 (0)
5,764 (+20)
5,317 (+20)
5,335 (+20)
5,968 (+20)
5,509 (+20)
+0.33%
+0.36%
0.00%
+0.35%
+0.38%
+0.38%
+0.34%
+0.36%
6,115 (0)
5,613 (0)
10,448 (0)
5,764 (0)
5,317 (0)
5,335 (0)
5,979 (0)
5,520 (0)
0.00%
0.00%
0.00%
0.00%
0.00%
0.00%
0.00%
0.00%
262 (0)
262 (0)
532 (0)
260 (0)
259 (0)
260 (0)
262 (0)
518 (0)
Bytes32StringHarness 405,794 (0) toString 1,141 (0) 0.00% 10,529 (+3) +0.03% 12,890 (-205) -1.57% 14,265 (0) 0.00% 292 (0)

@github-actions
Copy link
Copy Markdown

LCOV of commit 4bc86eb during Forge Coverage #133

Summary coverage rate:
  lines......: 86.3% (246 of 285 lines)
  functions..: 87.3% (69 of 79 functions)
  branches...: no data found

Files changed coverage rate:
                                     |Lines       |Functions  |Branches    
  Filename                           |Rate     Num|Rate    Num|Rate     Num
  =========================================================================
  src/ERC20Extended.sol              |31.2%     32| 0.0%    10|    -      0

@PierrickGT PierrickGT merged commit 60fe138 into feat/add-safe32 May 14, 2025
2 checks passed
@PierrickGT PierrickGT deleted the feat/erc20-extended-upgradeable branch May 14, 2025 21:39
PierrickGT added a commit that referenced this pull request May 15, 2025
Co-authored-by: Michael De Luca <michael.deluca@circle-free.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants