Skip to content

Add CI testing for GENTENSOR=1 compilation #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fbischoff merged 3 commits into from
Feb 19, 2026
Merged

Add CI testing for GENTENSOR=1 compilation #654

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
186493c
Initial plan
Copilot Feb 19, 2026
8353012
Add GENTENSOR=1 compilation testing to CI workflow
Copilot Feb 19, 2026
10cc6a6
Fix GENTENSOR compilation errors in lowranktensor.h
Copilot Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/cmake.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,14 @@ jobs:
cxx: /usr/bin/g++-13
- os: macos-latest
cxx: clang++
# Add GENTENSOR test configuration
- os: ubuntu-24.04
build_type: Debug
task_backend: Threads
cxx: /usr/bin/g++-13
gentensor: ON

name: "${{ matrix.os }}: ${{ matrix.cxx }} ${{ matrix.build_type }} ${{ matrix.task_backend }}"
name: "${{ matrix.os }}: ${{ matrix.cxx }} ${{ matrix.build_type }} ${{ matrix.task_backend }}${{ matrix.gentensor && ' +GENTENSOR' || '' }}"
runs-on: ${{ matrix.os }}
env:
CXX : ${{ matrix.cxx }}
Expand All @@ -44,6 +50,7 @@ jobs:
-DCMAKE_CXX_STANDARD=${{ matrix.task_backend == 'Threads' && matrix.build_type == 'Debug' && '20' || '17' }}
-DMADNESS_BUILD_MADWORLD_ONLY=${{ matrix.task_backend != 'Threads' }}
-DMADNESS_BUILD_LIBRARIES_ONLY=${{ matrix.build_type == 'Debug' }}
-DENABLE_GENTENSOR=${{ matrix.gentensor || 'OFF' }}

steps:
- uses: actions/checkout@v4
Expand Down
7 changes: 4 additions & 3 deletions src/madness/tensor/lowranktensor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -962,17 +962,18 @@ class SliceLowRankTensor : public GenTensor<T> {
// all ctors are private, only accessible by GenTensor

/// default ctor
SliceLowRankTensor<T> () {}
SliceLowRankTensor() {}

/// ctor with a GenTensor; shallow
SliceLowRankTensor<T> (const GenTensor<T>& gt, const std::vector<Slice>& s)
SliceLowRankTensor(const GenTensor<T>& gt, const std::vector<Slice>& s)
: GenTensor<T>(const_cast<GenTensor<T>& > (gt)) {
// : Tensor<T>(const_cast<Tensor<T>&>(t)) //!!!!!!!!!!!
thisslice.fill(_);
for (int i=0; i<s.size(); ++i) thisslice[i]=s[i];
}

/// ctor with a GenTensor; shallow
SliceLowRankTensor<T> (const GenTensor<T>& gt, const std::array<Slice,TENSOR_MAXDIM>& s)
SliceLowRankTensor(const GenTensor<T>& gt, const std::array<Slice,TENSOR_MAXDIM>& s)
: GenTensor<T>(&gt), thisslice(s) {}

public:
Expand Down
Loading