Add CI testing for GENTENSOR=1 compilation#654
Merged
Conversation
Co-authored-by: fbischoff <7567292+fbischoff@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Modify CI to test compilation with -DGENTENSOR=1
Add CI testing for GENTENSOR=1 compilation
Feb 19, 2026
Contributor
|
@copilot : check the failing test and suggest a fix |
Co-authored-by: fbischoff <7567292+fbischoff@users.noreply.github.com>
Contributor
Author
Fixed in commit 10cc6a6. The GENTENSOR build was failing due to compilation errors in
The code now compiles successfully with GENTENSOR=ON. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds CI testing for GENTENSOR compilation and fixes pre-existing compilation errors that were discovered when enabling this feature.
Changes:
- Added a new CI matrix job to test GENTENSOR=ON builds on ubuntu-24.04 with Debug mode and Threads backend
- Fixed C++ syntax errors in SliceLowRankTensor template class constructors by removing incorrect template parameters
- Added missing array initialization in SliceLowRankTensor constructor to follow existing codebase patterns
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/cmake.yml | Adds new matrix entry for GENTENSOR testing with ubuntu-24.04, Debug, Threads, and appropriate job naming |
| src/madness/tensor/lowranktensor.h | Fixes template constructor syntax errors and adds missing thisslice array initialization |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI Modification: Add GENTENSOR=1 Testing ✅
Summary
CI Configuration: Modified
.github/workflows/cmake.ymlto add GENTENSOR testingcheck-short-madnesstargetBug Fix (commit 10cc6a6): Fixed pre-existing compilation errors in
src/madness/tensor/lowranktensor.h:<T>from SliceLowRankTensor constructor names (lines 965, 968, 975)thisslice.fill(_)initialization before populating from vector (line 970)The GENTENSOR build now compiles successfully. Waiting for CI approval to run full test suite.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.