Skip to content

Add CI testing for GENTENSOR=1 compilation#654

Merged
fbischoff merged 3 commits intomasterfrom
copilot/modify-ci-testing-setup
Feb 19, 2026
Merged

Add CI testing for GENTENSOR=1 compilation#654
fbischoff merged 3 commits intomasterfrom
copilot/modify-ci-testing-setup

Conversation

Copy link
Contributor

Copilot AI commented Feb 19, 2026

CI Modification: Add GENTENSOR=1 Testing ✅

  • Explore repository structure and understand CI workflow
  • Identify CI configuration file (.github/workflows/cmake.yml)
  • Understand GENTENSOR CMake option (-DENABLE_GENTENSOR=1)
  • Understand short test target (check-short-madness)
  • Add new CI job matrix entry to include GENTENSOR=1 build
  • Configure the new job to run short tests only
  • Validate YAML syntax is correct
  • Investigate failing GENTENSOR test
  • Fix compilation errors in lowranktensor.h
  • Verify fix locally - build succeeds
  • Run CodeQL security analysis - no issues
  • Reply to user comment with fix details

Summary

CI Configuration: Modified .github/workflows/cmake.yml to add GENTENSOR testing

  • Added matrix entry: ubuntu-24.04 + Debug + Threads + GENTENSOR=ON
  • Tests run via existing check-short-madness target
  • Job name includes "+GENTENSOR" suffix for easy identification

Bug Fix (commit 10cc6a6): Fixed pre-existing compilation errors in src/madness/tensor/lowranktensor.h:

  1. Removed incorrect template parameter <T> from SliceLowRankTensor constructor names (lines 965, 968, 975)
  2. Added thisslice.fill(_) initialization before populating from vector (line 970)

The GENTENSOR build now compiles successfully. Waiting for CI approval to run full test suite.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: fbischoff <7567292+fbischoff@users.noreply.github.com>
Copilot AI changed the title [WIP] Modify CI to test compilation with -DGENTENSOR=1 Add CI testing for GENTENSOR=1 compilation Feb 19, 2026
Copilot AI requested a review from fbischoff February 19, 2026 08:25
@fbischoff
Copy link
Contributor

@copilot : check the failing test and suggest a fix

Co-authored-by: fbischoff <7567292+fbischoff@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Feb 19, 2026

@copilot : check the failing test and suggest a fix

Fixed in commit 10cc6a6. The GENTENSOR build was failing due to compilation errors in lowranktensor.h:

  1. Constructor names incorrectly included template parameter <T> (should be just SliceLowRankTensor() not SliceLowRankTensor<T>())
  2. Missing initialization of thisslice array before populating it from vector

The code now compiles successfully with GENTENSOR=ON.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/repos/m-a-d-n-e-s-s/madness/actions/runs/22175033634/jobs
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (http block)

If you need me to access, download, or install something from one of these locations, you can either:

@fbischoff fbischoff marked this pull request as ready for review February 19, 2026 10:22
Copilot AI review requested due to automatic review settings February 19, 2026 10:22
@fbischoff fbischoff merged commit 741e577 into master Feb 19, 2026
28 checks passed
@fbischoff fbischoff deleted the copilot/modify-ci-testing-setup branch February 19, 2026 10:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds CI testing for GENTENSOR compilation and fixes pre-existing compilation errors that were discovered when enabling this feature.

Changes:

  • Added a new CI matrix job to test GENTENSOR=ON builds on ubuntu-24.04 with Debug mode and Threads backend
  • Fixed C++ syntax errors in SliceLowRankTensor template class constructors by removing incorrect template parameters
  • Added missing array initialization in SliceLowRankTensor constructor to follow existing codebase patterns

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/cmake.yml Adds new matrix entry for GENTENSOR testing with ubuntu-24.04, Debug, Threads, and appropriate job naming
src/madness/tensor/lowranktensor.h Fixes template constructor syntax errors and adds missing thisslice array initialization

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants