Closed
Conversation
winston-h-zhang
force-pushed
the
preallocate-msm
branch
4 times, most recently
from
c230152 to
44fff73
Compare
huitseeker
pushed a commit
to huitseeker/arecibo
that referenced
this pull request
Jan 14, 2024
* test: msm test * refactor: batch invert and error flag * Apply suggestions from @huitseeker's code review
winston-h-zhang
force-pushed
the
preallocate-msm
branch
from
6876c06 to
44bee5d
Compare
Contributor
|
Is this still relevant? if not, should we close this? |
gabriel-barrett
pushed a commit
to gabriel-barrett/arecibo
that referenced
this pull request
Feb 9, 2024
* feat: Refactor error handling and variable naming - Implement marking of `NovaError` enum as non-exhaustive in `errors.rs`. - Introduce a new error case `InvalidCommitmentKeyLength` in `NovaError` enum that checks the length of the provided commitment key. - Improve code readability by renaming `generators_hint` variable to `ck_hint` in the `commitment_key` function. * test: msm test and refactoring (lurk-lang#254) * test: msm test * refactor: batch invert and error flag * Apply suggestions from @huitseeker's code review --------- Co-authored-by: ashWhiteHat <phantomofrotten@gmail.com>
Contributor
|
Closed in favor of #306, @winston-h-zhang feel free to reopen if relevant |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.