Merged
Conversation
- Implement marking of `NovaError` enum as non-exhaustive in `errors.rs`. - Introduce a new error case `InvalidCommitmentKeyLength` in `NovaError` enum that checks the length of the provided commitment key. - Improve code readability by renaming `generators_hint` variable to `ck_hint` in the `commitment_key` function.
* test: msm test * refactor: batch invert and error flag * Apply suggestions from @huitseeker's code review
mpenciak
reviewed
Nov 10, 2023
Contributor
mpenciak
left a comment
mpenciak
left a comment
There was a problem hiding this comment.
Small typo, but otherwise looks good!
|
|
||
| // check if the (relaxed) R1CS instances have two public outputs | ||
| if self.l_u_secondary.X.len() != 2 | ||
| let is_instance_has_two_outpus = self.l_u_secondary.X.len() != 2 |
Contributor
There was a problem hiding this comment.
Suggested change
| let is_instance_has_two_outpus = self.l_u_secondary.X.len() != 2 | |
| let is_instance_has_two_outputs = self.l_u_secondary.X.len() != 2 |
nit: typo
porcuquine
pushed a commit
to porcuquine/arecibo
that referenced
this pull request
Nov 28, 2023
* feat: Refactor error handling and variable naming - Implement marking of `NovaError` enum as non-exhaustive in `errors.rs`. - Introduce a new error case `InvalidCommitmentKeyLength` in `NovaError` enum that checks the length of the provided commitment key. - Improve code readability by renaming `generators_hint` variable to `ck_hint` in the `commitment_key` function. * test: msm test and refactoring (lurk-lang#254) * test: msm test * refactor: batch invert and error flag * Apply suggestions from @huitseeker's code review --------- Co-authored-by: ashWhiteHat <phantomofrotten@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports: