Merged
Conversation
Signed-off-by: Arnaud <arnaud@status.im>
Signed-off-by: Arnaud <arnaud@status.im>
Signed-off-by: Arnaud <arnaud@status.im>
Signed-off-by: Arnaud <arnaud@status.im>
…pointer Signed-off-by: Arnaud <arnaud@status.im>
Signed-off-by: Arnaud <arnaud@status.im>
benbierens
force-pushed
the
update-to-nim-2-x
branch
from
421c0c3 to
a969b97
Compare
benbierens
requested review from
AuHau,
benbierens,
dryajov,
emizzle and
markspanbroek
benbierens
previously approved these changes
Feb 11, 2025
emizzle
requested changes
Feb 12, 2025
datastore.nimble
Outdated
| "leveldbstatic >= 0.1.6", | ||
| "stew", | ||
| "unittest2" | ||
| "sqlite3_abi == 3.47.0.0", |
Contributor
There was a problem hiding this comment.
Do other minor versions break the build? eg
Suggested change
| "sqlite3_abi == 3.47.0.0", | |
| "sqlite3_abi >= 3.47.0.0 & < 4.0.0.0", |
datastore.nimble
Outdated
| "stew", | ||
| "unittest2" | ||
| "sqlite3_abi == 3.47.0.0", | ||
| "leveldbstatic >= 0.2.0 & < 1.0.0", |
Contributor
There was a problem hiding this comment.
I think a lot of nim libs use the second digit as a major version indicator 🤷 It should not be the case imo.
Suggested change
| "leveldbstatic >= 0.2.0 & < 1.0.0", | |
| "leveldbstatic >= 0.2.0 & < 0.3.0", |
datastore.nimble
Outdated
Comment on lines
+15
to
+16
| "stew >= 0.2.0", | ||
| "unittest2 >= 0.2.3" |
Contributor
There was a problem hiding this comment.
Suggested change
| "stew >= 0.2.0", | |
| "unittest2 >= 0.2.3" | |
| "stew >= 0.2.0 & < 0.3.0", | |
| "unittest2 >= 0.2.3 & < 0.3.0" |
emizzle
approved these changes
Feb 13, 2025
benbierens
approved these changes
Feb 13, 2025
Signed-off-by: Arnaud <arnaud@status.im>
2-towns
force-pushed
the
update-to-nim-2-x
branch
from
ed85482 to
f9deb5a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the changes to move to Nim 2.0. It includes dependency updates and one fix for trying to set nil to a distinct pointer, which is no longer supported by Nim 2.0:
7e053e5