Skip to content

Update to nim 2 x#104

Merged
emizzle merged 21 commits intomasterfrom
update-to-nim-2-x
Feb 14, 2025
Merged

Update to nim 2 x#104
emizzle merged 21 commits intomasterfrom
update-to-nim-2-x

Conversation

@2-towns
Copy link
Copy Markdown
Contributor

@2-towns 2-towns commented Dec 13, 2024

This PR contains the changes to move to Nim 2.0.

It is depending on PR of nim-datastore not merged yet.

@2-towns
Copy link
Copy Markdown
Contributor Author

2-towns commented Dec 18, 2024

ValidIpAddress has been deprecated in nim-stew and replace in nimbus-eth2.

@2-towns 2-towns marked this pull request as ready for review January 8, 2025 07:52
@2-towns 2-towns mentioned this pull request Jan 8, 2025
Closed
@cskiraly
Copy link
Copy Markdown
Contributor

cskiraly commented Feb 4, 2025 •
edited
Loading

LGTM
@2-towns , can you update this according to the changes in nim-datastore, if needed?
I see logos-storage/logos-storage-nim#1010 is referencing it, but logos-storage/nim-datastore#75 is still open.

@2-towns
Copy link
Copy Markdown
Contributor Author

2-towns commented Feb 5, 2025

LGTM @2-towns , can you update this according to the changes in nim-datastore, if needed? I see codex-storage/nim-codex#1010 is referencing it, but codex-storage/nim-datastore#75 is still open.

Yes logos-storage/nim-datastore#75 needs to be merged, I am waiting for a review.

emizzle
emizzle requested changes Feb 12, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@emizzle emizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to get these dependencies unipinned from commits as they prevent leniency when building the dependency graph and has come back to bite us many times.

Comment thread codexdht.nimble Outdated
@emizzle emizzle mentioned this pull request Feb 13, 2025
Merged
@emizzle
Copy link
Copy Markdown
Collaborator

emizzle commented Feb 13, 2025

#105 amends this branch

emizzle
emizzle approved these changes Feb 14, 2025
View reviewed changes
Comment thread codexdht.nimble Outdated
@emizzle emizzle merged commit f6eef1a into master Feb 14, 2025
@emizzle emizzle deleted the update-to-nim-2-x branch February 14, 2025 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emizzle emizzle emizzle approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@2-towns @cskiraly @emizzle @benbierens