Skip to content

[libc] Add invoke #65753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gchatelet wants to merge 3 commits into from
Closed

[libc] Add invoke #65753

gchatelet wants to merge 3 commits into from

Conversation

@gchatelet
Copy link
Contributor

@gchatelet gchatelet commented Sep 8, 2023 •
edited
Loading

@github-actions github-actions bot added the libc label Sep 8, 2023
@gchatelet gchatelet changed the title Add invoke [libc] Add invoke Sep 8, 2023
lntue
lntue reviewed Sep 8, 2023
View reviewed changes
libc/src/__support/CPP/type_traits/invoke_result.h
};

template <class F, class... Args, class Fd = typename cpp::decay_t<F>>
auto INVOKE(F &&f, Args &&...args)
Copy link
Contributor

@lntue lntue Sep 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this all caps?

Copy link
Contributor Author

@gchatelet gchatelet Sep 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a concept defined by the standard "23.14.3 [func.require]". INVOKE (all caps) serves as a foundation for defining std::invoke and std::invoke_result.

@gchatelet
Copy link
Contributor Author

gchatelet commented Sep 13, 2023

Will be implemented in #65750

@gchatelet gchatelet closed this Sep 13, 2023
@gchatelet gchatelet deleted the invoke branch September 13, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lntue lntue lntue left review comments

@legrosbuffle legrosbuffle Awaiting requested review from legrosbuffle

@rupprecht rupprecht Awaiting requested review from rupprecht rupprecht will be requested when the pull request is marked ready for review rupprecht is a code owner

@keith keith Awaiting requested review from keith keith will be requested when the pull request is marked ready for review keith is a code owner

@aaronmondal aaronmondal Awaiting requested review from aaronmondal aaronmondal will be requested when the pull request is marked ready for review aaronmondal is a code owner

Assignees

No one assigned

Labels

libc

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gchatelet @lntue