[libc] Add is_object #65749
Merged
[libc] Add is_object #65749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 8, 2023
Closed
legrosbuffle
approved these changes
Sep 8, 2023
lntue
reviewed
Sep 8, 2023
Contributor
lntue
left a comment
lntue
left a comment
There was a problem hiding this comment.
Do you also need to add this new header to CMakeLists.txt somewhere?
gchatelet
force-pushed
the
is_object
branch
from
3ab6912 to
78306e2
Compare
Contributor
Author
|
@legrosbuffle I've added a test, do you want to take another look? |
legrosbuffle
approved these changes
Sep 11, 2023
ZijunZhaoCCK
pushed a commit
to ZijunZhaoCCK/llvm-project
that referenced
this pull request
Sep 19, 2023
Add the is_object type traits. Implementation comes from https://en.cppreference.com/w/cpp/types/is_object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the is_object type traits.
Implementation comes from https://en.cppreference.com/w/cpp/types/is_object