[LLVM-Test] Fix a regression in test dependencies introduced by 0e14973

[jurahul]

Add UnitTests as an explicit dependency for check-llvm and llvm-test-depends. In #161442, the intent was to remove UnitTests as a dependency for the individual per-directory check-llvm-* test suites created but not to drop it from check-llvm or llvm-test-depends. This missing dependency will cause LLVM unit tests to be not rebuilt and resulting in either warning: test suite 'LLVM-Unit' contained no tests or running stale running versions of the unit tests when running check-llvm.

[jurahul]

Try no 3, restore UnitTests as a dependency for check-llvm

[jurahul]

Thanks @chapuni for identifying this issue. This means our CI builds did not run LLVM unit tests during this period :(

[jurahul]

I verified that of the 3 references to LLVM_TEST_DEPENDS only the one in add_lit_testsuites needs to not have UnitTests (already part of #161442) and the other 2 are the ones being updated here to add UnitTests.

[chapuni]

I expect it should work. Thanks for working.

[llvm-ci]

LLVM Buildbot has detected a new failure on builder clang-ppc64le-linux-multistage running on ppc64le-clang-multistage-test while building llvm at step 4 "build stage 1".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/76/builds/13060

Here is the relevant piece of the build log for the reference

Step 4 (build stage 1) failure: 'ninja' (failure) (timed out)
...
[380/6535] Building CXX object lib/TableGen/CMakeFiles/LLVMTableGen.dir/TGParser.cpp.o
[381/6535] Building CXX object lib/TableGen/CMakeFiles/LLVMTableGen.dir/StringToOffsetTable.cpp.o
[382/6535] Building CXX object lib/TableGen/CMakeFiles/LLVMTableGen.dir/TGTimer.cpp.o
[383/6535] Linking CXX executable bin/llvm-PerfectShuffle
[384/6535] Linking CXX shared library lib/libLLVMDemangle.so.22.0git
[385/6535] Creating library symlink lib/libLLVMDemangle.so
[386/6535] Linking CXX shared library lib/libbenchmark.so.0.0.0
[387/6535] Creating library symlink lib/libbenchmark.so.0 lib/libbenchmark.so
[388/6535] Linking CXX shared module unittests/Support/DynamicLibrary/PipSqueak.so
[389/6535] Linking CXX shared module unittests/Support/DynamicLibrary/SecondLib.so
command timed out: 1200 seconds without output running [b'ninja'], attempting to kill
process killed by signal 9
program finished with exit code -1
elapsedTime=1408.956740