[NFC][LLVM-Tests] Specialize test suite for LLVM unit tests#161442
Merged
[NFC][LLVM-Tests] Specialize test suite for LLVM unit tests#161442
Conversation
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/27/builds/16894 Here is the relevant piece of the build log for the reference |
Contributor
|
I wonder this would suppress |
Contributor
Author
|
It should not, so not intentional. I think these tests should still be a part of check-all atleast and check-llvm as well. Let me test a little bit to confirm tomorrow |
Contributor
Author
|
IIRC check-llvm and check-all are their own standalone targets independent of the check-llvm-* targets, but will check |
Contributor
Author
|
Here's the command generated for check-llvm: So, this will run everything under llvm/test, including the unit tests. Locally I do see several |
Contributor
Author
|
But for additional verification I created this PR with a broken unit test, expecting that it will fail the checks: #161623 |
Contributor
|
Could you try again with cleaning unittests? |
Contributor
Author
|
It does not. And isn't that expected? It's no longer a part of |
Contributor
|
I expect e.g. https://lab.llvm.org/buildbot/#/builders/199/builds/6235/steps/12/logs/stdio |
Contributor
Author
|
I see, so I think we need to add UnitTest as a explicit dependency for both |
Contributor
Author
|
Ok. in the latest test PR version, I do see that the 2 faulty unit tests do fail: |
s-barannikov
reviewed
Oct 2, 2025
| @@ -0,0 +1,5 @@ | |||
| add_lit_testsuite(check-llvm-unit "Running lit suite for LLVM unit tests" | |||
| ${CMAKE_CURRENT_BINARY_DIR} | |||
| EXCLUDE_FROM_CHECK_ALL | |||
Contributor
There was a problem hiding this comment.
Why is it unconditional EXCLUDE_FROM_CHECK_ALL? It looks conditional on the left.
Contributor
Author
There was a problem hiding this comment.
See similar PR for the earlier specialized suites: #159781
Without EXCLUDE_FROM_CHECK_ALL, these tests run twice, which is wasteful and sometimes leading to failure due to concurrent execution (which will likely not affect these unit tests).
jurahul
added a commit
that referenced
this pull request
Oct 2, 2025
… (#161623) Add `UnitTests` as an explicit dependency for `check-llvm` and `llvm-test-depends`. In #161442, the intent was to remove `UnitTests` as a dependency for the individual per-directory `check-llvm-*` test suites created but not to drop it from `check-llvm` or `llvm-test-depends`. This missing dependency will cause LLVM unit tests to be not rebuilt and resulting in either `warning: test suite 'LLVM-Unit' contained no tests` or running stale running versions of the unit tests when running `check-llvm`.
llvm-sync Bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Oct 2, 2025
…ed by 0e14973 (#161623) Add `UnitTests` as an explicit dependency for `check-llvm` and `llvm-test-depends`. In llvm/llvm-project#161442, the intent was to remove `UnitTests` as a dependency for the individual per-directory `check-llvm-*` test suites created but not to drop it from `check-llvm` or `llvm-test-depends`. This missing dependency will cause LLVM unit tests to be not rebuilt and resulting in either `warning: test suite 'LLVM-Unit' contained no tests` or running stale running versions of the unit tests when running `check-llvm`.
mahesh-attarde
pushed a commit
to mahesh-attarde/llvm-project
that referenced
this pull request
Oct 3, 2025
mahesh-attarde
pushed a commit
to mahesh-attarde/llvm-project
that referenced
this pull request
Oct 3, 2025
… (llvm#161623) Add `UnitTests` as an explicit dependency for `check-llvm` and `llvm-test-depends`. In llvm#161442, the intent was to remove `UnitTests` as a dependency for the individual per-directory `check-llvm-*` test suites created but not to drop it from `check-llvm` or `llvm-test-depends`. This missing dependency will cause LLVM unit tests to be not rebuilt and resulting in either `warning: test suite 'LLVM-Unit' contained no tests` or running stale running versions of the unit tests when running `check-llvm`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
UnitTestsfrom LLVM_TEST_DEPENDS_COMMON and create a specialized lit suite for unit-tests and that depends only onUnitTests.