Skip to content

Add encryption metadata for data packets #1127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukasIO merged 19 commits into from
Aug 18, 2025
Merged

Add encryption metadata for data packets #1127

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
1616e18
override minimatch version
lukasIO Jun 20, 2025
27351c1
Merge branch 'main' of github.com:livekit/protocol
lukasIO Jul 8, 2025
3bf41ea
Add encryption metadata for data packets
lukasIO Jul 9, 2025
b200091
generated protobuf
github-actions[bot] Jul 9, 2025
d81a8ce
add key index
lukasIO Jul 11, 2025
25c36ae
Merge branch 'lukas/dc-encrypt' of github.com:livekit/protocol into l…
lukasIO Jul 11, 2025
cb78833
generated protobuf
github-actions[bot] Jul 11, 2025
329f582
encrypt envelope
lukasIO Jul 11, 2025
63b075b
generated protobuf
github-actions[bot] Jul 11, 2025
207e8f9
more explicit encryption messages
lukasIO Jul 11, 2025
65c0ca8
generated protobuf
github-actions[bot] Jul 11, 2025
3cfd639
whitespace
lukasIO Jul 11, 2025
7e38e5b
Merge branch 'main' into lukas/dc-encrypt
lukasIO Aug 15, 2025
5cb9527
Create cold-feet-worry.md
lukasIO Aug 15, 2025
c84e019
try fix build
lukasIO Aug 15, 2025
dbc8ace
Merge branch 'lukas/dc-encrypt' of github.com:livekit/protocol into l…
lukasIO Aug 15, 2025
66c1cd5
manual fix
lukasIO Aug 15, 2025
49a6c14
generated protobuf
github-actions[bot] Aug 15, 2025
aa824e2
next id
lukasIO Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
159 changes: 108 additions & 51 deletions livekit/livekit_models.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 7 additions & 2 deletions protobufs/livekit_models.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,8 +315,9 @@ message UserPacket {
optional uint64 end_time = 10;
// added by SDK to enable de-duping of messages, for INTERNAL USE ONLY
bytes nonce = 11;

// NEXT_ID: 12
Encryption.Type encryption_type = 12; // defaults to NONE
bytes iv = 13;
Copy link
Contributor

@bcherry bcherry Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is iv for?

Copy link
Contributor Author

@lukasIO lukasIO Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://developer.mozilla.org/en-US/docs/Web/API/AesGcmParams#iv

a necessary unique initialisation vector for each encryption operation

// NEXT_ID: 14
}

message SipDTMF {
Expand Down Expand Up @@ -357,6 +358,8 @@ message RpcRequest {
string payload = 3;
uint32 response_timeout_ms = 4;
uint32 version = 5;
Encryption.Type encryption_type = 6; // defaults to NONE
bytes iv = 7;
}

message RpcAck {
Expand All @@ -369,6 +372,8 @@ message RpcResponse {
string payload = 2;
RpcError error = 3;
}
Encryption.Type encryption_type = 4; // defaults to NONE
bytes iv = 5;
}

message RpcError {
Expand Down