Skip to content

Conversation

@lukasIO
Copy link
Contributor

@lukasIO lukasIO commented Jul 9, 2025

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jul 9, 2025

🦋 Changeset detected

Latest commit: aa824e2

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "github.com/livekit/protocol" specified in the `fixed` option does not match any package in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.


// NEXT_ID: 12
Encryption.Type encryption_type = 12; // defaults to NONE
bytes iv = 13;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is iv for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://developer.mozilla.org/en-US/docs/Web/API/AesGcmParams#iv

a necessary unique initialisation vector for each encryption operation

@lukasIO lukasIO marked this pull request as ready for review August 15, 2025 09:45
Copy link

@cloudwebrtc cloudwebrtc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@lukasIO lukasIO requested a review from a team August 18, 2025 10:32
@lukasIO lukasIO merged commit 72e862b into main Aug 18, 2025
7 checks passed
@lukasIO lukasIO deleted the lukas/dc-encrypt branch August 18, 2025 11:04
@github-actions github-actions bot mentioned this pull request Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants