Skip to content

[Mellanox] [ECMP calculator] Add script usage and more information to script description #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
liorghub wants to merge 2 commits into from
+5 −4
Closed

[Mellanox] [ECMP calculator] Add script usage and more information to script description #36

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
151e898
Add script usage and more information to script description being pri…
liorghub Jan 18, 2023
833614c
Update debug flag help message
liorghub Jan 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions platform/mellanox/docker-syncd-mlnx/ecmp_calculator/ecmp_calc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,11 +482,12 @@ def validate_packet_json(self, packet_json):
def main():
rc = 0
try:
parser = argparse.ArgumentParser(description="ECMP calculator")
parser.add_argument("-i", "--interface", required=True, help="Ingress interface")
parser.add_argument("-p", "--packet", required=True, help="Packet description")
parser = argparse.ArgumentParser(description="Calculate egress interface for the given packet being routed over ECMP",
usage="/usr/bin/ecmp_calc.py -i <ingress interface> -p <path to json>")
parser.add_argument("-i", "--interface", required=True, help="ingress interface")
parser.add_argument("-p", "--packet", required=True, help="json file describing a packet")
parser.add_argument("-v", "--vrf", help="VRF name")
parser.add_argument("-d", "--debug", default=False, action="store_true", help="Flag for debug")
parser.add_argument("-d", "--debug", default=False, action="store_true", help="flag for debug")
Copy link
Copy Markdown
Collaborator

@dprital dprital Jan 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add description what the debug option provide (info from SDK, verbose, etc.)

Copy link
Copy Markdown
Owner Author

@liorghub liorghub Jan 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dprital Done.

args = parser.parse_args()

ecmp_calc = EcmpCalc()
Expand Down