[Mellanox] [ECMP calculator] Add script usage and more information to script description#36
Closed
[Mellanox] [ECMP calculator] Add script usage and more information to script description#36
Conversation
…nted in help option
dprital
requested changes
Jan 20, 2023
| parser.add_argument("-p", "--packet", required=True, help="json file describing a packet") | ||
| parser.add_argument("-v", "--vrf", help="VRF name") | ||
| parser.add_argument("-d", "--debug", default=False, action="store_true", help="Flag for debug") | ||
| parser.add_argument("-d", "--debug", default=False, action="store_true", help="flag for debug") |
Collaborator
There was a problem hiding this comment.
Please add description what the debug option provide (info from SDK, verbose, etc.)
dprital
approved these changes
Jan 24, 2023
liorghub
pushed a commit
that referenced
this pull request
Apr 19, 2023
67a3bdf show counters wrong cli output fixed (#36) 5b3eea1 Update package cache, and bail on the first error (#35) 1d221b0 dhcpv6 relay UT code coverage improve (#32) 514b084 dhcpv6 packet handling code refine (#30) Signed-off-by: Vivek Reddy <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add script usage and more information to script description being printed in help option.
Why I did it
Missing information in script description.
How I did it
Expand script description and add script usage.
How to verify it
N/A
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)