deps: [M3-9804] - Upgrade Vite to 6.3.x #12074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman-akamai
added
the
Dependencies
bnussman-akamai
requested review from
abailly-akamai and
cpathipa
and removed request for
a team
bnussman-akamai
commented
Apr 21, 2025
| import type { AlertFilterKey, EngineType } from './types'; | ||
|
|
||
| import type { AlertFilterKey } from './types'; | ||
| const engineOptions: EngineType[] = [ |
There was a problem hiding this comment.
I made this change because there was a circular dependency here causing a unit test failure
packages/manager/src/features/CloudPulse/Alerts/AlertsResources/AlertsEngineTypeFilter.tsx ➡️ packages/manager/src/features/CloudPulse/Alerts/AlertsResources/constants.ts ➡️ packages/manager/src/features/CloudPulse/Alerts/AlertsResources/AlertsEngineTypeFilter.tsx
abailly-akamai
approved these changes
Apr 22, 2025
| "@typescript-eslint/eslint-plugin": "^8.29.0", | ||
| "@typescript-eslint/parser": "^8.29.0", | ||
| "@linode/eslint-plugin-cloud-manager": "^0.0.10", | ||
| "jiti": "^2.4.2" |
There was a problem hiding this comment.
Oh?! I thought i had removed it
coliu-akamai
approved these changes
Apr 22, 2025
Cloud Manager UI test results🔺 1 failing test on test run #5 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: pnpm cy:run -s "cypress/e2e/core/linodes/clone-linode.spec.ts" |
|||||||||||||||||
This was referenced May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
6.3.xto resolve https://github.com/linode/manager/security/dependabot/1613.1.xpnpm --recursive update @babel/runtimeandpnpm --recursive update @babel/helpersto resolve@babel/helpersand@babel/runtimeto latest #11864.... Not sure what caused the versions to go back... If it happens agian, we may want to use a resolution of figure out another plan@types/uuidpackagejitipackageHow to test 🧪
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅