Skip to content

Conversation

@bnussman-akamai
Copy link
Member

@bnussman-akamai bnussman-akamai commented Mar 17, 2025

Description 📝

To do this, I used these commands

pnpm --recursive update @babel/helpers
pnpm --recursive update @babel/runtime

Usually I don't like making "magic" changes to the lockfile, but I think in cases like this it should be okay. I believe we'd get the same version bumps on @babel/runtime and @babel/helpers if we were to delete the lockfile and regenerate it. This is just a less destructive way to bump these deep dependencies.

How to test 🧪

  • Checkout this PR
  • Use pnpm why -r @babel/runtime and pnpm why -r @babel/helpers to ensure that their versions are patched
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@bnussman-akamai bnussman-akamai added the Dependencies Pull requests that update a dependency file label Mar 17, 2025
@bnussman-akamai bnussman-akamai self-assigned this Mar 17, 2025
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner March 17, 2025 16:13
@bnussman-akamai bnussman-akamai requested review from harsh-akamai and mjac0bs and removed request for a team March 17, 2025 16:13
@github-actions
Copy link

Coverage Report:
Base Coverage: 79.82%
Current Coverage: 79.82%

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 539 passing tests on test run #2 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing539 Passing3 Skipped109m 2s

Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Versions are updated in all packages

@mjac0bs mjac0bs added the Add'tl Approval Needed Waiting on another approval! label Mar 17, 2025
@github-project-automation github-project-automation bot moved this from Review to Approved in Cloud Manager Mar 17, 2025
@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Mar 18, 2025
@bnussman-akamai bnussman-akamai merged commit 4a73d84 into linode:develop Mar 18, 2025
27 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in Cloud Manager Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved Multiple approvals and ready to merge! Dependencies Pull requests that update a dependency file

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants