Skip to content

chore: transform_updates=false code paths better #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raboof merged 3 commits into from
Jul 1, 2021
Merged

chore: transform_updates=false code paths better #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
57ecf59
Document `transform_updates=false` code paths better
raboof Jun 30, 2021
11c383c
scalafmt
raboof Jul 1, 2021
fe669d1
javafmt
raboof Jul 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sdk/src/main/java/com/akkaserverless/javasdk/AkkaServerless.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,7 +477,8 @@ public AkkaServerless registerValueEntity(
}

/**
* Experimental API: Register a view.
* Experimental API: Register a view that has `transform_updates=false` set, so it can be handled
* by the proxy.
*
* @param descriptor The descriptor of the view.
* @param viewId The id of this view, used for persistence.
Expand Down
4 changes: 3 additions & 1 deletion sdk/src/main/scala/com/akkaserverless/javasdk/impl/view/ViewsImpl.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,9 @@ final class ViewsImpl(system: ActorSystem, _services: Map[String, ViewService],
case Some(service: ViewService) =>
if (!service.factory.isPresent)
throw new IllegalArgumentException(
s"Unexpected call to service [${receiveEvent.serviceName}] with viewId [${service.viewId}]."
s"Unexpected call to service [${receiveEvent.serviceName}] with viewId [${service.viewId}]: " +
"this view has `transform_updates=false` set, so updates should be handled entirely by the proxy " +
"and not reach the user function"
)

val handler = service.factory.get.create(new ViewContextImpl(service.viewId))
Expand Down