fix(codegen-java): support outer classes in typeName#618
Merged
octonato merged 5 commits intolightbend:mainfrom Oct 13, 2021
Merged
fix(codegen-java): support outer classes in typeName#618octonato merged 5 commits intolightbend:mainfrom
octonato merged 5 commits intolightbend:mainfrom
Conversation
And add tests, and use it in more places. This also required more explicitly stripping the outer class information from the proto descriptor import logic.
Probably needs to be revisited later though
raboof
force-pushed
the
fix-typeName-outer-class-handling
branch
from
b8af19c to
155b2d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And add tests, and use it in more places. This also required more
explicitly stripping the outer class information from the proto descriptor
import logic.