feat(codegen-java): 'external' value entity state types#620
Merged
raboof merged 3 commits intolightbend:mainfrom Oct 14, 2021
Merged
feat(codegen-java): 'external' value entity state types#620raboof merged 3 commits intolightbend:mainfrom
raboof merged 3 commits intolightbend:mainfrom
Conversation
raboof
force-pushed
the
support-relative-value-entity-state-type
branch
from
2a2745a to
8aedc08
Compare
raboof
commented
Oct 13, 2021
| option java_outer_classname = "UserrDomain"; | ||
|
|
||
| option (akkaserverless.file).value_entity = { | ||
| name: "Userr" |
Contributor
Author
There was a problem hiding this comment.
I plan to use this as a testcase for the fix for #437, changing it back to User then ;)
johanandren
approved these changes
Oct 13, 2021
| option java_outer_classname = "UserrDomain"; | ||
|
|
||
| option (akkaserverless.file).value_entity = { | ||
| name: "Userr" |
| log: Log, | ||
| fqnExtractor: FullyQualifiedNameExtractor): FullyQualifiedName = { | ||
| // TODO this is used in the java tck as ValueEntity state type - I'm not sure we want to | ||
| // support this? In that case we should probably support all primitives? |
Contributor
There was a problem hiding this comment.
AnySupport does support primitives, wrapping them in an protobuf Any I think, but I also doubt we should support that. Another of those flexibilities just making what you actually can/should do hard to understand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #614
This does the 'java' 'value entity' part of this task. I'll continue doing "more of the same" for eventsourced and replicated entities, and for the Scala side, but this should be mergable in-between as well.