Skip to content

chore: remove obsolete build job #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
octonato merged 1 commit into from
Oct 7, 2021
Merged

chore: remove obsolete build job #575

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,20 +176,6 @@ jobs:
command: sbt test codegenCore/publishLocal codegenScala/publishLocal sdkCore/publishLocal sdkJava/publishLocal sdkScala/publishLocal sdkJavaTestKit/publishLocal sdkScalaTestKit/publishLocal scripted
- save_deps_cache

integration-tests:
machine: true
description: "Integration tests"
steps:
- checkout-and-merge-to-main
- setup_sbt
- restore_deps_cache
- run:
name: Run integration tests
# FIXME enable again
#command: docker-compose -f .circleci/google-pubsub-emulator-docker-compose.yml up -d && sbt samples/It/test
command: sbt compile
Comment on lines -189 to -190
Copy link
Copy Markdown
Member Author

@octonato octonato Oct 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is only compiling once more and the integration tests are not run in the sample jobs (when applicable).

Copy link
Copy Markdown
Member Author

@octonato octonato Oct 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record, it seems that we don't have a job only doing the compilation.
This is done in the testings job only. I'm fine with that, but maybe that was not the intention.

In any case, if want to do a compilation round first, we should instead do it in the checks job and also compile the tests.

Copy link
Copy Markdown
Contributor

@johanandren johanandren Oct 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that is fine for the samples, they all compile in their own job so to speak. Doing it in the checks would delay all other tasks since everything depends on that so I think we should avoid making that take longer time.

- save_deps_cache

tck-tests:
machine: true
description: "TCK tests"
Expand Down Expand Up @@ -655,10 +641,6 @@ workflows:
requires:
- checks

- integration-tests:
requires:
- checks

- tck-tests:
requires:
- checks
Expand Down