Conversation
| #command: docker-compose -f .circleci/google-pubsub-emulator-docker-compose.yml up -d && sbt samples/It/test | ||
| command: sbt compile |
There was a problem hiding this comment.
this is only compiling once more and the integration tests are not run in the sample jobs (when applicable).
There was a problem hiding this comment.
For the record, it seems that we don't have a job only doing the compilation.
This is done in the testings job only. I'm fine with that, but maybe that was not the intention.
In any case, if want to do a compilation round first, we should instead do it in the checks job and also compile the tests.
There was a problem hiding this comment.
I think that is fine for the samples, they all compile in their own job so to speak. Doing it in the checks would delay all other tasks since everything depends on that so I think we should avoid making that take longer time.
| #command: docker-compose -f .circleci/google-pubsub-emulator-docker-compose.yml up -d && sbt samples/It/test | ||
| command: sbt compile |
There was a problem hiding this comment.
I think that is fine for the samples, they all compile in their own job so to speak. Doing it in the checks would delay all other tasks since everything depends on that so I think we should avoid making that take longer time.
I was talking about a full compilation cycle, ie: The samples are compiled in their own job and that's ok. Note that the previous job here was doing: |
No description provided.