Skip to content

chore: remove obsolete build job#575

Merged
octonato merged 1 commit intomainfrom
rgc/remove-obsolte-build-phase
Oct 7, 2021
Merged

chore: remove obsolete build job#575
octonato merged 1 commit intomainfrom
rgc/remove-obsolte-build-phase

Conversation

@octonato
Copy link
Copy Markdown
Member

@octonato octonato commented Oct 7, 2021

No description provided.

Comment thread .circleci/config.yml
Comment on lines -189 to -190
#command: docker-compose -f .circleci/google-pubsub-emulator-docker-compose.yml up -d && sbt samples/It/test
command: sbt compile
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is only compiling once more and the integration tests are not run in the sample jobs (when applicable).

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record, it seems that we don't have a job only doing the compilation.
This is done in the testings job only. I'm fine with that, but maybe that was not the intention.

In any case, if want to do a compilation round first, we should instead do it in the checks job and also compile the tests.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that is fine for the samples, they all compile in their own job so to speak. Doing it in the checks would delay all other tasks since everything depends on that so I think we should avoid making that take longer time.

Comment thread .circleci/config.yml
Comment on lines -189 to -190
#command: docker-compose -f .circleci/google-pubsub-emulator-docker-compose.yml up -d && sbt samples/It/test
command: sbt compile
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that is fine for the samples, they all compile in their own job so to speak. Doing it in the checks would delay all other tasks since everything depends on that so I think we should avoid making that take longer time.

@octonato
Copy link
Copy Markdown
Member Author

octonato commented Oct 7, 2021

I think that is fine for the samples, they all compile in their own job so to speak. Doing it in the checks would delay all other tasks since everything depends on that so I think we should avoid making that take longer time.

I was talking about a full compilation cycle, ie: sbt test:compile. We could do it if we can guarantee that here is no double compilation. But I'm fine to let it happen when we run the tests.

The samples are compiled in their own job and that's ok. Note that the previous job here was doing: sbt compile, not sbt samples/compile. We don't even have a samples parent module anymore.

@octonato octonato merged commit 0128586 into main Oct 7, 2021
@octonato octonato deleted the rgc/remove-obsolte-build-phase branch October 7, 2021 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants