Skip to content

fix: changed to ServiceCall to ServiceCallDetails #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johanandren merged 1 commit into from
Oct 7, 2021
Merged

fix: changed to ServiceCall to ServiceCallDetails #573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions testkit-java/src/main/java/com/akkaserverless/javasdk/testkit/ActionResult.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
import java.util.Iterator;
import java.util.List;
import java.util.NoSuchElementException;
import com.akkaserverless.javasdk.ServiceCall;
import com.akkaserverless.javasdk.testkit.ServiceCallDetails;
import java.util.concurrent.CompletionStage;
import com.akkaserverless.javasdk.action.Action;

Expand All @@ -34,7 +34,7 @@ public interface ActionResult<T> {
boolean isForward();

/** @return ServiceCall representing a call to a service */
ServiceCall getForwardServiceCall();
ServiceCallDetails getForwardServiceCall();

/** @return true if the call was async, false if not */
boolean isAsync();
Expand Down
15 changes: 10 additions & 5 deletions testkit-java/src/main/scala/com/akkaserverless/javasdk/testkit/impl/ActionResultImpl.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ package com.akkaserverless.javasdk.testkit.impl
import com.akkaserverless.javasdk.testkit.ActionResult
import com.akkaserverless.javasdk.impl.action.ActionEffectImpl
import com.akkaserverless.javasdk.action.Action
import com.akkaserverless.javasdk.ServiceCall
import com.akkaserverless.javasdk.testkit.ServiceCallDetails
import com.akkaserverless.javasdk.testkit.impl.TestKitServiceCallFactory
import java.util.concurrent.CompletionStage;
import scala.concurrent.Future;
import scala.compat.java8.FutureConverters._
Expand All @@ -42,10 +43,14 @@ final class ActionResultImpl[T](effect: Action.Effect[T]) extends ActionResult[T
/** @return true if the call was forwarded, false if not */
def isForward(): Boolean = effect.isInstanceOf[ActionEffectImpl.ForwardEffect[T]]

def getForwardServiceCall(): ServiceCall = {
val forward = getEffectOfType(classOf[ActionEffectImpl.ForwardEffect[T]])
forward.serviceCall
}
def getForwardServiceCall(): ServiceCallDetails[T] =
effect match {
case ActionEffectImpl.ForwardEffect(serviceCall: TestKitServiceCallFactory.TestKitServiceCall[T @unchecked], _) =>
serviceCall
case _ =>
throw new IllegalStateException(
"expected effect type [ActionEffectImpl.ForwardEffect] but found [" + effect.getClass.getName + "]")
}

// TODO rewrite
/** @return true if the call was async, false if not */
Expand Down