fix: changed to ServiceCall to ServiceCallDetails#573
Merged
johanandren merged 1 commit intolightbend:mainfrom Oct 7, 2021
Merged
Conversation
Contributor
|
Yep exactly that. 👍 |
johanandren
approved these changes
Oct 7, 2021
Contributor
johanandren
left a comment
johanandren
left a comment
There was a problem hiding this comment.
LGTM, but the exception text if the type is wrong is not quite correct as it is not only about the effect type but also the service call type (not super important though)
Contributor
Author
|
I see. Understood. I'll change the message in other PR? |
franciscolopezsancho
changed the title
Contributor
|
Ups, forgot about the conventional commits, sorry. |
Contributor
Author
|
I added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let me know if this is what you meant @johanandren