chore: move unmanagedComment between imports and class#570
Merged
Conversation
octonato
commented
Oct 6, 2021
Comment on lines
76
to
+77
| s"""package ${service.fqn.parent.javaPackage}; | ||
| | | ||
| |$imports | ||
| | | ||
| |$managedComment | ||
| | | ||
| |public final class $testKitClassName { | ||
| | | ||
| | private Function<ActionCreationContext, $className> actionFactory; | ||
| | | ||
| | private $className createAction() { | ||
| | $className action = actionFactory.apply(new StubActionCreationContext()); | ||
| | action._internalSetActionContext(Optional.of(new StubActionContext())); | ||
| | return action; | ||
| | }; | ||
| | | ||
| | public static $testKitClassName of(Function<ActionCreationContext, $className> actionFactory) { | ||
| | return new $testKitClassName(actionFactory); | ||
| | } | ||
| | | ||
| | private $testKitClassName(Function<ActionCreationContext, $className> actionFactory) { | ||
| | this.actionFactory = actionFactory; | ||
| | } | ||
| | | ||
| | private <E> ActionResult<E> interpretEffects(Action.Effect<E> effect) { | ||
| | return new ActionResultImpl(effect); | ||
| | } | ||
| | | ||
| | ${Format.indent(generateServices(service), 2)} | ||
| | | ||
| |} | ||
| |""".stripMargin | ||
| | |
Member
Author
There was a problem hiding this comment.
just because I want to see the | aligned with the p. :-)
Contributor
There was a problem hiding this comment.
shouldn't it align just before the p? 😆
Contributor
There was a problem hiding this comment.
why not add the | at the first line then
Member
Author
There was a problem hiding this comment.
I will do it. I'm trying to hold a balance here and not look like a total formatting freak. :-)
octonato
commented
Oct 6, 2021
| | | ||
| |$imports | ||
| | | ||
| |$unmanagedComment |
Member
Author
There was a problem hiding this comment.
this is the real motivation for this PR. A leftover from #503
raboof
approved these changes
Oct 6, 2021
Comment on lines
76
to
+77
| s"""package ${service.fqn.parent.javaPackage}; | ||
| | | ||
| |$imports | ||
| | | ||
| |$managedComment | ||
| | | ||
| |public final class $testKitClassName { | ||
| | | ||
| | private Function<ActionCreationContext, $className> actionFactory; | ||
| | | ||
| | private $className createAction() { | ||
| | $className action = actionFactory.apply(new StubActionCreationContext()); | ||
| | action._internalSetActionContext(Optional.of(new StubActionContext())); | ||
| | return action; | ||
| | }; | ||
| | | ||
| | public static $testKitClassName of(Function<ActionCreationContext, $className> actionFactory) { | ||
| | return new $testKitClassName(actionFactory); | ||
| | } | ||
| | | ||
| | private $testKitClassName(Function<ActionCreationContext, $className> actionFactory) { | ||
| | this.actionFactory = actionFactory; | ||
| | } | ||
| | | ||
| | private <E> ActionResult<E> interpretEffects(Action.Effect<E> effect) { | ||
| | return new ActionResultImpl(effect); | ||
| | } | ||
| | | ||
| | ${Format.indent(generateServices(service), 2)} | ||
| | | ||
| |} | ||
| |""".stripMargin | ||
| | |
Contributor
There was a problem hiding this comment.
shouldn't it align just before the p? 😆
Member
Author
Don't tease me or I will format all the things! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was reviewing #503 and spotted this, but PR got merged in the meantime.
Also contains some minor formatting.