Skip to content

Asserting different effects#503

Merged
franciscolopezsancho merged 29 commits intolightbend:mainfrom
franciscolopezsancho:asserting-different-effects
Oct 6, 2021
Merged

Asserting different effects#503
franciscolopezsancho merged 29 commits intolightbend:mainfrom
franciscolopezsancho:asserting-different-effects

Conversation

@franciscolopezsancho
Copy link
Copy Markdown
Contributor

@franciscolopezsancho franciscolopezsancho commented Sep 26, 2021 •
edited by patriknw
Loading

  • creating ad-hoc testkit to test Actions.
    Created a Testkit in java-eventsourced-counter for CounterJournalToTopicAction
    Created one test for it. Test passing.
  • create codegen.
    Created Testkit thorught codegen. Test passing.
    Added loading user-function.desc from sample. To generate exact BuilderModel.Model
    Added codegen for generating examples on src/test
  • add docs.

Refs #336

@franciscolopezsancho
created stub and test
4d1d018
@franciscolopezsancho
first test passing
99c870b 
CounterJournalToTopicActionTest is passing now.
johanandren
johanandren reviewed Sep 27, 2021
View reviewed changes
Comment thread ...ventsourced-counter/src/main/java/com/example/domain/CounterJournalToTopicActionTestKit.java Outdated
Comment thread ...ventsourced-counter/src/main/java/com/example/domain/CounterJournalToTopicActionTestKit.java Outdated
Comment thread testkit-java/src/main/java/com/akkaserverless/javasdk/testkit/ActionResult.java Outdated
johanandren
johanandren reviewed Sep 27, 2021
View reviewed changes
Comment thread testkit-java/src/main/java/com/akkaserverless/javasdk/testkit/ActionResult.java Outdated
Comment thread testkit-java/src/main/java/com/akkaserverless/javasdk/testkit/ActionResult.java Outdated
Comment thread testkit-java/src/main/scala/com/akkaserverless/javasdk/testkit/impl/StubActionContext.scala Outdated
Comment thread testkit-java/src/main/scala/com/akkaserverless/javasdk/testkit/impl/StubActionContext.scala Outdated
patriknw
patriknw reviewed Sep 28, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good

Comment thread ...a-eventsourced-counter/src/test/java/com/example/domain/CounterJournalToTopicActionTest.java Outdated
johanandren
johanandren reviewed Sep 29, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@johanandren johanandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress!

Comment thread codegen/java-gen/src/main/scala/com/lightbend/akkasls/codegen/java/ActionTestKitGenerator.scala Outdated
Comment thread codegen/java-gen/src/main/scala/com/lightbend/akkasls/codegen/java/ActionTestKitGenerator.scala Outdated
Comment thread ...java-gen/src/test/scala/com/lightbend/akkasls/codegen/java/ActionTestKitGeneratorSuite.scala
Comment thread ...entsourced-counter/src/main/java/com/example/actions/CounterJournalToTopicActionTestKit.java Outdated
Comment thread testkit-java/src/main/java/com/akkaserverless/javasdk/testkit/ActionResult.java Outdated
Comment thread testkit-java/src/main/java/com/akkaserverless/javasdk/testkit/ActionResult.java Outdated
Comment thread testkit-java/src/main/java/com/akkaserverless/javasdk/testkit/ActionResult.java Outdated
@franciscolopezsancho
Codegen already functional
df0528a 
It's get generated and currently used in java-eventsourced-counter. Test passing
johanandren
johanandren reviewed Oct 4, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@johanandren johanandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's shaping up nicely!

Comment thread ...java-gen/src/test/scala/com/lightbend/akkasls/codegen/java/ActionTestKitGeneratorSuite.scala Outdated
Comment thread testkit-java/src/main/java/com/akkaserverless/javasdk/testkit/ActionResult.java Outdated
Comment thread testkit-java/src/main/scala/com/akkaserverless/javasdk/testkit/impl/ActionResultImpl.scala Outdated
@franciscolopezsancho
Added test example generation
28a9b8a 
also accepted suggestions
johanandren
johanandren reviewed Oct 4, 2021
View reviewed changes
Comment thread ...java-gen/src/test/scala/com/lightbend/akkasls/codegen/java/ActionTestKitGeneratorSuite.scala Outdated
Comment thread sdk/java-sdk/src/main/java/com/akkaserverless/javasdk/action/ActionContext.java Outdated
@franciscolopezsancho franciscolopezsancho marked this pull request as ready for review October 4, 2021 18:40
johanandren
johanandren reviewed Oct 5, 2021
View reviewed changes
Comment thread ...java-gen/src/test/scala/com/lightbend/akkasls/codegen/java/ActionTestKitGeneratorSuite.scala
Comment thread codegen/java-gen/src/main/scala/com/lightbend/akkasls/codegen/java/ActionTestKitGenerator.scala Outdated
@franciscolopezsancho
Merge branch 'main' of github.com:franciscolopezsancho/akkaserverless…
b862130 
…-java-sdk into asserting-different-effects
@franciscolopezsancho
adding missing import
ee4f266 
fixing naming in generated test example
octonato
octonato reviewed Oct 5, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@octonato octonato left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

Added a few comments and suggestions

Comment thread ...-eventsourced-counter/src/test/java/com/example/actions/CounterJournalToTopicActionTest.java
Comment thread docs/src/modules/java/pages/actions.adoc Outdated
Comment thread ...java-gen/src/test/scala/com/lightbend/akkasls/codegen/java/ActionTestKitGeneratorSuite.scala
Comment thread docs/src/modules/java/pages/actions.adoc Outdated
Comment thread docs/src/modules/java/pages/actions.adoc Outdated
franciscolopezsancho and others added 6 commits October 5, 2021 11:02
@franciscolopezsancho
changing selectInput/Output from ModelBuilder.Commands
e79b1c3
@franciscolopezsancho @octonato
Update docs/src/modules/java/pages/actions.adoc
75deb3d 
Co-authored-by: Renato Cavalcanti <renato@cavalcanti.be>
@franciscolopezsancho @octonato
Update docs/src/modules/java/pages/actions.adoc
e417a83 
Co-authored-by: Renato Cavalcanti <renato@cavalcanti.be>
@franciscolopezsancho @octonato
Update docs/src/modules/java/pages/actions.adoc
b221a9e 
Co-authored-by: Renato Cavalcanti <renato@cavalcanti.be>
@franciscolopezsancho @octonato
Update samples/java-eventsourced-counter/src/test/java/com/example/ac…
997678f 
…tions/CounterJournalToTopicActionTest.java

Co-authored-by: Renato Cavalcanti <renato@cavalcanti.be>
@franciscolopezsancho
adding codegen for RPCs streaming, client and server
1fa4764 
previously only Unary
@franciscolopezsancho
adding comment after imports
fb1ee72 
plus removing unnecesary package naming
johanandren
johanandren reviewed Oct 5, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@johanandren johanandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing up on being done this one. 👍

Comment thread docs/src/modules/java/pages/actions.adoc Outdated
Comment thread docs/src/modules/java/pages/actions.adoc Outdated
Comment thread docs/src/modules/java/pages/actions.adoc Outdated
Comment thread docs/src/modules/java/pages/actions.adoc Outdated
Comment thread docs/src/modules/java/pages/actions.adoc Outdated
Comment thread docs/src/modules/java/pages/actions.adoc Outdated
Comment thread docs/src/modules/java/pages/actions.adoc Outdated
franciscolopezsancho and others added 5 commits October 6, 2021 08:31
@franciscolopezsancho @johanandren
Update docs/src/modules/java/pages/actions.adoc
f4bb328 
Co-authored-by: Johan Andrén <johan@markatta.com>
@franciscolopezsancho @johanandren
Update docs/src/modules/java/pages/actions.adoc
c65d83e 
Co-authored-by: Johan Andrén <johan@markatta.com>
@franciscolopezsancho @johanandren
Update docs/src/modules/java/pages/actions.adoc
c0b2e8a 
Co-authored-by: Johan Andrén <johan@markatta.com>
@franciscolopezsancho @johanandren
Update docs/src/modules/java/pages/actions.adoc
10a7894 
Co-authored-by: Johan Andrén <johan@markatta.com>
@franciscolopezsancho
adding suggestions
eee315b
@franciscolopezsancho @johanandren
Update docs/src/modules/java/pages/actions.adoc
ba010e0 
Co-authored-by: Johan Andrén <johan@markatta.com>
johanandren
johanandren reviewed Oct 6, 2021
View reviewed changes
Comment thread docs/src/modules/java/pages/actions.adoc Outdated
@franciscolopezsancho @johanandren
Update docs/src/modules/java/pages/actions.adoc
34524db 
Co-authored-by: Johan Andrén <johan@markatta.com>
johanandren
johanandren approved these changes Oct 6, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@johanandren johanandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good work!

@franciscolopezsancho franciscolopezsancho merged commit 44f986f into lightbend:main Oct 6, 2021
This was referenced Oct 6, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@octonato octonato octonato left review comments

@johanandren johanandren johanandren approved these changes

@patriknw patriknw Awaiting requested review from patriknw

Assignees

No one assigned

Labels

java-sdk-protobuf

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@franciscolopezsancho @patriknw @octonato @johanandren @ennru