feat(codegen-scala): value entity provider#474
Merged
patriknw merged 5 commits intolightbend:mainfrom Sep 23, 2021
Merged
Conversation
patriknw
reviewed
Sep 23, 2021
| val file = | ||
| provider(testData.valueEntity(domainParent), testData.simpleEntityService(apiParent)) | ||
| assertNoDiff( | ||
| file.content, |
Contributor
There was a problem hiding this comment.
ok, then we have a cleanup task to align all other generation to return File instead of String
(consistency police here)
Contributor
Author
There was a problem hiding this comment.
I'd like that ;) (and yeah, we have a bunch of consistency things to clean up ;) ). Will PR.
raboof
force-pushed
the
value-entity-provider
branch
from
01b67e4 to
bc7efde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let's finish this up after merging #469 so we can actually hook up the handler