feat(scalasdk): codegen for ValueEntityHandler.#469
Merged
Conversation
RayRoestenburg
force-pushed
the
ray/value-entity-handler-codegen
branch
from
de9716e to
9ae18cc
Compare
Contributor
Author
|
|
RayRoestenburg
force-pushed
the
ray/value-entity-handler-codegen
branch
4 times, most recently
from
736daa2 to
d40a9de
Compare
raboof
approved these changes
Sep 23, 2021
| extends Entity(fqn, entityType) { | ||
| val abstractEntityName = "Abstract" + fqn.name | ||
|
|
||
| val handlerName = fqn.name + "Handler" |
Contributor
There was a problem hiding this comment.
(I wonder if it would be nicer to keep them in fqn form here, but that's not for this PR)
RayRoestenburg
force-pushed
the
ray/value-entity-handler-codegen
branch
from
d40a9de to
faa1383
Compare
patriknw
reviewed
Sep 23, 2021
Contributor
patriknw
left a comment
patriknw
left a comment
There was a problem hiding this comment.
looking good, but one thing could be wrong...
| "com.akkaserverless.scalasdk.valueentity.CommandContext", | ||
| "com.akkaserverless.scalasdk.valueentity.ValueEntity", | ||
| "com.akkaserverless.scalasdk.impl.valueentity.ValueEntityHandler", | ||
| "com.akkaserverless.scalasdk.impl.valueentity.ValueEntityHandler.CommandHandlerNotFound"), |
Contributor
There was a problem hiding this comment.
This might be wrong. In View and Actions we used the corresponding javasdk exception instead of defining a new in scalasdk. It's not something seen by the user. In that we we don't need to catch-convert-throw.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.